Skip to content

Commit

Permalink
feat: add priorityClassName support to helm chart (#4357)
Browse files Browse the repository at this point in the history
* Add priorityClassName support to helm chart

Signed-off-by: jukie <10012479+Jukie@users.noreply.github.com>

* fix

Signed-off-by: jukie <10012479+Jukie@users.noreply.github.com>

* actually fix

Signed-off-by: jukie <10012479+Jukie@users.noreply.github.com>

* format

Signed-off-by: jukie <10012479+Jukie@users.noreply.github.com>

---------

Signed-off-by: jukie <10012479+Jukie@users.noreply.github.com>
Co-authored-by: Xunzhuo <bitliu@tencent.com>
  • Loading branch information
jukie and Xunzhuo authored Sep 29, 2024
1 parent 652f6ba commit 6edf452
Show file tree
Hide file tree
Showing 7 changed files with 585 additions and 0 deletions.
1 change: 1 addition & 0 deletions charts/gateway-helm/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -91,6 +91,7 @@ To uninstall the chart:
| deployment.ports[3].name | string | `"metrics"` | |
| deployment.ports[3].port | int | `19001` | |
| deployment.ports[3].targetPort | int | `19001` | |
| deployment.priorityClassName | string | `nil` | |
| deployment.replicas | int | `1` | |
| global.images.envoyGateway.image | string | `nil` | |
| global.images.envoyGateway.pullPolicy | string | `nil` | |
Expand Down
3 changes: 3 additions & 0 deletions charts/gateway-helm/templates/envoy-gateway-deployment.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -94,6 +94,9 @@ spec:
name: certs
readOnly: true
{{- include "eg.image.pullSecrets" . | nindent 6 }}
{{- with .Values.deployment.priorityClassName }}
priorityClassName: {{ . | quote }}
{{- end }}
serviceAccountName: envoy-gateway
terminationGracePeriodSeconds: 10
volumes:
Expand Down
1 change: 1 addition & 0 deletions charts/gateway-helm/values.tmpl.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,7 @@ deployment:
- name: metrics
port: 19001
targetPort: 19001
priorityClassName: null
replicas: 1
pod:
affinity: {}
Expand Down
1 change: 1 addition & 0 deletions site/content/en/latest/install/gateway-helm-api.md
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,7 @@ The Helm chart for Envoy Gateway
| deployment.ports[3].name | string | `"metrics"` | |
| deployment.ports[3].port | int | `19001` | |
| deployment.ports[3].targetPort | int | `19001` | |
| deployment.priorityClassName | string | `nil` | |
| deployment.replicas | int | `1` | |
| global.images.envoyGateway.image | string | `nil` | |
| global.images.envoyGateway.pullPolicy | string | `nil` | |
Expand Down
1 change: 1 addition & 0 deletions site/content/zh/latest/install/gateway-helm-api.md
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,7 @@ The Helm chart for Envoy Gateway
| deployment.ports[3].name | string | `"metrics"` | |
| deployment.ports[3].port | int | `19001` | |
| deployment.ports[3].targetPort | int | `19001` | |
| deployment.priorityClassName | string | `nil` | |
| deployment.replicas | int | `1` | |
| global.images.envoyGateway.image | string | `nil` | |
| global.images.envoyGateway.pullPolicy | string | `nil` | |
Expand Down
7 changes: 7 additions & 0 deletions test/helm/gateway-helm/deployment-priorityclass.in.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
global:
images:
envoyGateway:
image: "docker.io/envoyproxy/gateway-dev:latest"
pullPolicy: Always
deployment:
priorityClassName: system-cluster-critical
Loading

0 comments on commit 6edf452

Please sign in to comment.