fix test

Signed-off-by: zirain <zirain2009@gmail.com>
envoyproxy · Apr 26, 2024 · 720dec7 · 720dec7
1 parent 48379cb
commit 720dec7
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 7 deletions.
diff --git a/internal/provider/kubernetes/controller_test.go b/internal/provider/kubernetes/controller_test.go
@@ -156,7 +156,7 @@ func TestHasManagedClass(t *testing.T) {
 
  testCases := []struct {
  name string
- ep client.Object
+ ep *egv1a1.EnvoyProxy
  classes []*gwapiv1.GatewayClass
  expected bool
  }{

diff --git a/internal/provider/kubernetes/predicates_test.go b/internal/provider/kubernetes/predicates_test.go
@@ -33,18 +33,18 @@ import (
 func TestGatewayClassHasMatchingController(t *testing.T) {
  testCases := []struct {
  name string
- obj client.Object
+ gc  *gwapiv1.GatewayClass
  client client.Client
  expect bool
  }{
  {
  name: "matching controller name",
- obj: test.GetGatewayClass("test-gc", v1alpha1.GatewayControllerName, nil),
+ gc:  test.GetGatewayClass("test-gc", v1alpha1.GatewayControllerName, nil),
  expect: true,
  },
  {
  name: "non-matching controller name",
- obj: test.GetGatewayClass("test-gc", "not.configured/controller", nil),
+ gc:  test.GetGatewayClass("test-gc", "not.configured/controller", nil),
  expect: false,
  },
  }
@@ -60,7 +60,7 @@ func TestGatewayClassHasMatchingController(t *testing.T) {
  for _, tc := range testCases {
  tc := tc
  t.Run(tc.name, func(t *testing.T) {
- res := r.hasMatchingController(tc.obj)
+ res := r.hasMatchingController(tc.gc)
  require.Equal(t, tc.expect, res)
  })
  }

diff --git a/internal/provider/kubernetes/sources_test.go b/internal/provider/kubernetes/sources_test.go
@@ -59,8 +59,8 @@ func TestSources(t *testing.T) {
  for _, tc := range testCases {
  t.Run(tc.name, func(t *testing.T) {
  cond := make(chan struct{})
- store := NewWatchAndReconcileSource(cond, tc.obj)
- err := store.Start(tc.ctx, tc.handler, tc.queue)
+ store := NewWatchAndReconcileSource(cond, tc.obj, tc.handler)
+ err := store.Start(tc.ctx, tc.queue)
  if !tc.expected {
  require.Error(t, err)
  } else {