Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Investigate Gateway/HTTPRouteObservedGenerationBump Test Flakes #1016

Closed
danehans opened this issue Feb 9, 2023 · 2 comments · Fixed by #1153
Closed

Investigate Gateway/HTTPRouteObservedGenerationBump Test Flakes #1016

danehans opened this issue Feb 9, 2023 · 2 comments · Fixed by #1153
Labels
area/ci CI and build related issues area/conformance Gateway API Conformance Related Issues help wanted Extra attention is needed kind/bug Something isn't working priority/high Label used to express the "high" priority level
Milestone
0.4.0-rc.1

Comments

@danehans
Copy link
Contributor

danehans commented Feb 9, 2023

HTTPRouteObservedGenerationBump seems to be flaky.

xref: #1014 (comment)
@danehans danehans added the kind/bug Something isn't working label Feb 9, 2023
@danehans danehans added the area/ci CI and build related issues label Feb 9, 2023
@danehans danehans added this to the 0.4.0-rc.1 milestone Feb 9, 2023
This was referenced Feb 9, 2023
Merged
Merged
Merged
@danehans danehans added the priority/high Label used to express the "high" priority level label Feb 9, 2023
@danehans danehans mentioned this issue Feb 9, 2023
Merged
@arkodg
Copy link
Contributor

arkodg commented Feb 9, 2023

@Xunzhuo I tagged you because I thought these were related to the GatewayClassObservedGenerationBump Test, but they are tied to Gateway and HTTPRoute, my bad, unassigning you

@arkodg arkodg added help wanted Extra attention is needed area/conformance Gateway API Conformance Related Issues labels Feb 9, 2023
@Xunzhuo Xunzhuo changed the title Investigate HTTPRouteObservedGenerationBump Test Flakes Investigate Gateway/HTTPRouteObservedGenerationBump Test Flakes Feb 10, 2023
@arkodg arkodg mentioned this issue Mar 1, 2023
Merged
@Alice-Lilith
Copy link
Member

Should be able to un-skip these with the release of Gateway API 0.6.2 next week.

@arkodg arkodg mentioned this issue Mar 21, 2023
Merged
arkodg added a commit that referenced this issue Mar 22, 2023
@arkodg
Bump to Gateway API v0.6.2 (#1153)
6936ac7 
* Bumps gateway-api version to `v0.6.2`
* Ensure the status or code do not refer to any resource as `Ready`, because we cannot guarantee that today, raised  #1171 to fix it
* Refactor `gateway-api` translator to ensure we always compute `ResolvedRefs` condition which is checked by the newer conformance tests
* Brings in kubernetes-sigs/gateway-api#1760 which removes some test flakes
  * enable`GatewayObservedGenerationBump` test
    * Fixes #1016
  * enable `HTTPRouteObservedGenerationBump` test
    * Fixes #1016
* Disable `GatewayWithAttachedRoutes` test which should be fixed with #1201

Fixes: #1152
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/ci CI and build related issues area/conformance Gateway API Conformance Related Issues help wanted Extra attention is needed kind/bug Something isn't working priority/high Label used to express the "high" priority level
Projects
None yet
Milestone
0.4.0-rc.1
Development

Successfully merging a pull request may close this issue.

Bump to Gateway API v0.6.2 arkodg/gateway
4 participants
@danehans @arkodg @Alice-Lilith @Xunzhuo