Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configurable Envoy Access Logging #280

Closed
danehans opened this issue Aug 30, 2022 · 5 comments
Closed

Configurable Envoy Access Logging #280

danehans opened this issue Aug 30, 2022 · 5 comments
Labels
area/infra-mgr Issues related to the provisioner used for provisioning the managed Envoy Proxy fleet. help wanted Extra attention is needed kind/enhancement New feature or request
Milestone

Comments

@danehans
Copy link
Contributor

Currently, Envoy access logs are sent to /dev/null. Users should have the ability to configure Envoy access logging through the EnvoyProxy API type.

@danehans danehans added kind/enhancement New feature or request area/infra-mgr Issues related to the provisioner used for provisioning the managed Envoy Proxy fleet. labels Aug 30, 2022
@danehans danehans added this to the Backlog milestone Aug 30, 2022
@danehans danehans added the help wanted Extra attention is needed label Aug 30, 2022
@danehans
Copy link
Contributor Author

In the meantime, do the following to enable access logging:

--- a/internal/infrastructure/kubernetes/bootstrap.yaml.tpl
+++ b/internal/infrastructure/kubernetes/bootstrap.yaml.tpl
@@ -1,5 +1,8 @@
 admin:
-  access_log_path: /dev/null
+  access_log:
+  - name: envoy.access_loggers.stdout
+    typed_config:
+      "@type": type.googleapis.com/envoy.extensions.access_loggers.stream.v3.StdoutAccessLog
   address:
     socket_address:
       address: {{ .AdminServerAddress }}

@arkodg
Copy link
Contributor

arkodg commented Aug 30, 2022

@danehans imho EG should propose a sane default such as ^ and any mod should be addressed via #31 / #24

@zirain
Copy link
Member

zirain commented Aug 30, 2022

for a short term, make bootstrap configurable seems enough.

for a long term, we may need something like Telemetry api in istio?

@lizan
Copy link
Member

lizan commented Aug 30, 2022

@danehans that is only for the admin endpoint, the other logs is configured via xDS component.

@zirain
Copy link
Member

zirain commented Jun 8, 2023

fixed by #1407 and #1464

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/infra-mgr Issues related to the provisioner used for provisioning the managed Envoy Proxy fleet. help wanted Extra attention is needed kind/enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants