Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: implement accesslog #1464

Merged
merged 9 commits into from
Jun 6, 2023
Merged

feat: implement accesslog #1464

merged 9 commits into from
Jun 6, 2023

Conversation

zirain
Copy link
Member

@zirain zirain commented May 30, 2023

What type of PR is this?

What this PR does / why we need it:

part of #699

Which issue(s) this PR fixes:

Fixes #

@zirain zirain requested a review from a team as a code owner May 30, 2023 03:21
@codecov
Copy link

codecov bot commented May 30, 2023 •
edited
Loading

Codecov Report

Merging #1464 (5b92910) into main (9f06d11) will decrease coverage by 0.14%.
The diff coverage is 56.72%.

@@            Coverage Diff             @@
##             main    #1464      +/-   ##
==========================================
- Coverage   61.51%   61.37%   -0.14%     
==========================================
  Files          79       80       +1     
  Lines       11536    11834     +298     
==========================================
+ Hits         7096     7263     +167     
- Misses       3975     4106     +131     
  Partials      465      465
Impacted Files Coverage Δ
api/config/v1alpha1/envoyproxy_types.go 100.00% <ø> (ø)
api/config/v1alpha1/zz_generated.deepcopy.go 0.00% <0.00%> (ø)
internal/ir/xds.go 71.66% <ø> (ø)
internal/ir/zz_generated.deepcopy.go 11.19% <0.00%> (-1.79%) ⬇️
internal/xds/translator/translator.go 80.67% <69.23%> (+0.38%) ⬆️
internal/gatewayapi/listener.go 90.79% <77.19%> (-7.32%) ⬇️
internal/xds/translator/accesslog.go 100.00% <100.00%> (ø)
internal/xds/translator/listener.go 82.37% <100.00%> (+0.09%) ⬆️

... and 2 files with indirect coverage changes

Xunzhuo
Xunzhuo reviewed Jun 1, 2023
View reviewed changes
Copy link
Member

@Xunzhuo Xunzhuo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on it. Some nits.

@zirain zirain force-pushed the accesslog branch 3 times, most recently from 7b53282 to 37daa13 Compare June 5, 2023 01:31
arkodg
arkodg previously approved these changes Jun 5, 2023
View reviewed changes
Copy link
Contributor

@arkodg arkodg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks !

@zirain zirain requested review from arkodg, Xunzhuo and qicz June 6, 2023 01:39
zirain added 9 commits June 6, 2023 09:40
@zirain
implement accesslog
8c4b201 
Signed-off-by: hejianpeng <hejianpeng2@huawei.com>
@zirain
fix test
745142a 
Signed-off-by: hejianpeng <hejianpeng2@huawei.com>
@zirain
fix TestTranslate
a034b02 
Signed-off-by: hejianpeng <hejianpeng2@huawei.com>
@zirain
fix processAccessLog
4e97c90 
Signed-off-by: hejianpeng <hejianpeng2@huawei.com>
@zirain
fix test
09dc36f 
Signed-off-by: hejianpeng <hejianpeng2@huawei.com>
@zirain
fix lint
b497902 
Signed-off-by: hejianpeng <hejianpeng2@huawei.com>
@zirain
fix tls tests
dafdf0d 
Signed-off-by: hejianpeng <hejianpeng2@huawei.com>
@zirain
rename
dc289b9 
Signed-off-by: hejianpeng <hejianpeng2@huawei.com>
@zirain
address review comment
5b92910 
Signed-off-by: hejianpeng <hejianpeng2@huawei.com>
qicz
qicz approved these changes Jun 6, 2023
View reviewed changes
Copy link
Member

@qicz qicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zirain zirain merged commit 07612ee into envoyproxy:main Jun 6, 2023
@zirain zirain deleted the accesslog branch June 6, 2023 06:09
@zirain zirain mentioned this pull request Jun 8, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qicz qicz qicz approved these changes

@arkodg arkodg arkodg approved these changes

@Xunzhuo Xunzhuo Awaiting requested review from Xunzhuo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@zirain @qicz @arkodg @Xunzhuo