Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configure different access log formats for gateways in the same gateway class #3773

Closed
benediktwerner opened this issue Jul 7, 2024 · 1 comment
Labels

Comments

@benediktwerner
Copy link

benediktwerner commented Jul 7, 2024

Currently, the access log format can be configured via an EnvoyProxy CRD which always applies to a whole gateway class, so it's not possible (at least not without patch policies) to configure different access log formats for different gateways in the same gateway class. In our case, we for example want to log various headers specific to each gateway.

Actually, this also applies to almost all of the other values that can be configured via EnvoyProxy, for example gateways managed by different teams may want to send their telemetry to different places or we might want to enable oauth debug logging for a single gateway to debug oauth issues related to its specific OIDC config.

So I wonder if it might even just make sense to somehow allow attaching an EnvoyProxy CRD to a single gateway (provided that mergeGateways is false for its gateway class, and I guess also disallowing setting mergeGateway in that case). In essence, a single (non-merged) gateway after all also just is a single envoy proxy instance, exactly what the EnvoyProxy CRD allows configuring.

@shawnh2
Copy link
Contributor

shawnh2 commented Jul 7, 2024

hi @benediktwerner, the EnvoyProxy CRD can be attached to gateway now thanks to #3532.

However, this feature is not documented, tracked by #3639. Will update documents soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants