Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: Attaching EnvoyProxy to Gateways #3639

Closed
arkodg opened this issue Jun 20, 2024 · 1 comment · Fixed by #4020
Closed

docs: Attaching EnvoyProxy to Gateways #3639

arkodg opened this issue Jun 20, 2024 · 1 comment · Fixed by #4020
Labels
documentation Improvements or additions to documentation help wanted Extra attention is needed
Milestone
v1.2.0

Comments

@arkodg
Copy link
Contributor

arkodg commented Jun 20, 2024 •
edited by Xunzhuo
Loading

Description:

Describe the issue.

Support for attaching envoyProxy to Gateways was added in #3532
https://gateway.envoyproxy.io/v1.0/tasks/operations/customize-envoyproxy/#add-gatewayclass-parametersref
our docs need to be updated to also highlight support for attaching to Gateway

[optional Relevant Links:]

Any extra documentation required to understand the issue.
@arkodg arkodg added triage help wanted Extra attention is needed and removed triage labels Jun 20, 2024
@arkodg arkodg added this to the v1.1.0 milestone Jun 20, 2024
@arkodg arkodg added the documentation Improvements or additions to documentation label Jun 20, 2024
@shawnh2 shawnh2 mentioned this issue Jul 7, 2024
Closed
@shawnh2 shawnh2 mentioned this issue Jul 20, 2024
Closed
@Xunzhuo
Copy link
Member

Xunzhuo commented Jul 20, 2024

Should note that: Support attaching EnvoyProxy resource to Gateways if MergeGateways is disabled on GatewayClass

@arkodg arkodg modified the milestones: v1.1.0, v1.2.0 Jul 31, 2024
arkodg added a commit to arkodg/gateway that referenced this issue Aug 8, 2024
@arkodg
docs: Attach EnvoyProxy to Gateway
a3c259a 
Fixes: envoyproxy#3639

Signed-off-by: Arko Dasgupta <arko@tetrate.io>
arkodg added a commit to arkodg/gateway that referenced this issue Aug 8, 2024
@arkodg
docs: Attach EnvoyProxy to Gateway
b1e5bd0 
Fixes: envoyproxy#3639

Signed-off-by: Arko Dasgupta <arko@tetrate.io>
(cherry picked from commit a3c259a)
Signed-off-by: Arko Dasgupta <arko@tetrate.io>
arkodg added a commit to arkodg/gateway that referenced this issue Aug 8, 2024
@arkodg
docs: Attach EnvoyProxy to Gateway
80d433e 
Fixes: envoyproxy#3639

Signed-off-by: Arko Dasgupta <arko@tetrate.io>
(cherry picked from commit a3c259a)
Signed-off-by: Arko Dasgupta <arko@tetrate.io>
@arkodg arkodg mentioned this issue Aug 8, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
documentation Improvements or additions to documentation help wanted Extra attention is needed
Projects
None yet
Milestone
v1.2.0
Development

Successfully merging a pull request may close this issue.

docs: Attach EnvoyProxy to Gateway arkodg/gateway
2 participants
@arkodg @Xunzhuo