Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ensure use_remote_address is set #1029

Merged
merged 4 commits into from
Feb 13, 2023
Merged

Conversation

zirain
Copy link
Contributor

@zirain zirain commented Feb 10, 2023

fixes: #998

cc @arkodg

Signed-off-by: hejianpeng <hejianpeng2@huawei.com>
Signed-off-by: hejianpeng <hejianpeng2@huawei.com>
@zirain zirain marked this pull request as ready for review February 10, 2023 07:27
@zirain zirain requested a review from a team as a code owner February 10, 2023 07:27
Signed-off-by: hejianpeng <hejianpeng2@huawei.com>
@zirain zirain force-pushed the use-remote-address branch from 5d12d6f to 9c46283 Compare February 10, 2023 07:39
arkodg
arkodg previously approved these changes Feb 10, 2023
Copy link
Contributor

@arkodg arkodg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks ! left a nit

Signed-off-by: hejianpeng <hejianpeng2@huawei.com>
@arkodg arkodg merged commit 5ae7766 into envoyproxy:main Feb 13, 2023
@zirain zirain deleted the use-remote-address branch February 15, 2023 01:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ensure use_remote_address is set
3 participants