Implement Bootstrap API #1094
Merged
Implement Bootstrap API #1094
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Relates to envoyproxy#31 Signed-off-by: Arko Dasgupta <arko@tetrate.io>
7 tasks
zirain
reviewed
Mar 3, 2023
Signed-off-by: Arko Dasgupta <arko@tetrate.io>
Signed-off-by: Arko Dasgupta <arko@tetrate.io>
Xunzhuo
reviewed
Mar 4, 2023
| // The config should have been validated already | ||
| if infra.Proxy.Config != nil && | ||
| infra.Proxy.Config.Spec.Bootstrap != nil { | ||
| cfg = *infra.Proxy.Config.Spec.Bootstrap |
There was a problem hiding this comment.
I think we should unmarshal it to bootstrap struct to validate it if the bootstrap user provided is invalid.
There was a problem hiding this comment.
the validation will happen in the validation webhook, and the data should be valid by the time it reaches this component
Xunzhuo
reviewed
Mar 4, 2023
|
|
||
| // Set a custom bootstrap config into EnvoyProxy API and ensure the same | ||
| // value is set as the container arg. | ||
| bstrap := "blah" |
There was a problem hiding this comment.
This is obvious a invalid bootstrap config I think? There should be an error reported.
There was a problem hiding this comment.
as I mentioned in the prevous comment, the validation will happen earlier. Just used a dummy string to test in this component.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to #31