Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump to gateway api v0.7.0 #1415

Merged
merged 8 commits into from
May 24, 2023
Merged

Bump to gateway api v0.7.0 #1415

merged 8 commits into from
May 24, 2023

Conversation

arkodg
Copy link
Contributor

@arkodg arkodg commented May 10, 2023

Fixes: #992
Fixes: #993
Fixes: #994

@arkodg arkodg requested a review from a team as a code owner May 10, 2023 21:50
@codecov
Copy link

codecov bot commented May 10, 2023

Codecov Report

Merging #1415 (33159b5) into main (a9a8528) will decrease coverage by 0.10%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #1415      +/-   ##
==========================================
- Coverage   62.07%   61.97%   -0.10%     
==========================================
  Files          79       79              
  Lines       11275    11275              
==========================================
- Hits         6999     6988      -11     
- Misses       3820     3828       +8     
- Partials      456      459       +3     

see 2 files with indirect coverage changes

Copy link
Member

@zirain zirain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wait for v0.7.0?

kflynn
kflynn previously approved these changes May 11, 2023
Copy link
Contributor

@kflynn kflynn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general, I think we should track all the Gateway API releases, given how infrequent they are. Let's go ahead and land this. 🙂

zirain
zirain previously approved these changes May 12, 2023
@zirain zirain added the cherrypick/release-v0.4 cherrypick to release/v0.4 label May 12, 2023
@zirain
Copy link
Member

zirain commented May 12, 2023

add a cherrypick label for action testing, please kindly ignore.

@Xunzhuo
Copy link
Member

Xunzhuo commented May 12, 2023

/hold

Error: test/conformance/conformance_test.go:55:3: unknown field ValidUniqueListenerPorts in struct literal of type suite.Options
FAIL	github.com/envoyproxy/gateway/test/conformance [build failed]

@arkodg arkodg dismissed stale reviews from zirain and kflynn via cf16d62 May 12, 2023 06:03
@arkodg arkodg force-pushed the bump-gwapi-again branch from aba1950 to cf16d62 Compare May 12, 2023 06:03
@arkodg arkodg removed the cherrypick/release-v0.4 cherrypick to release/v0.4 label May 12, 2023
@zirain
Copy link
Member

zirain commented May 16, 2023

wait v0.7.1 because of kubernetes-sigs/gateway-api#2024

@arkodg arkodg changed the title Bump to gateway api v0.7.0-rc2 Bump to gateway api v0.7.0 May 23, 2023
arkodg added 5 commits May 23, 2023 16:55
* Release notes https://github.com/kubernetes-sigs/gateway-api/releases/tag/v0.7.0-rc2
* Also re enable redirect tests because of the fixes made in those tests
  should make the tests API conformant :)

Signed-off-by: Arko Dasgupta <arko@tetrate.io>
Signed-off-by: Arko Dasgupta <arko@tetrate.io>
Signed-off-by: Arko Dasgupta <arko@tetrate.io>
Signed-off-by: Arko Dasgupta <arko@tetrate.io>
Signed-off-by: Arko Dasgupta <arko@tetrate.io>
@arkodg arkodg force-pushed the bump-gwapi-again branch from 5f9bce5 to 3b2f212 Compare May 23, 2023 23:57
arkodg added 3 commits May 23, 2023 17:05
Signed-off-by: Arko Dasgupta <arko@tetrate.io>
Signed-off-by: Arko Dasgupta <arko@tetrate.io>
Signed-off-by: Arko Dasgupta <arko@tetrate.io>
@arkodg arkodg force-pushed the bump-gwapi-again branch from 035246f to 33159b5 Compare May 24, 2023 01:13
@arkodg arkodg requested review from kflynn, zirain and a team and removed request for a team May 24, 2023 01:39
@arkodg arkodg requested review from a team May 24, 2023 01:45
Copy link
Member

@Xunzhuo Xunzhuo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great

@Xunzhuo Xunzhuo merged commit 3344221 into envoyproxy:main May 24, 2023
@arkodg arkodg deleted the bump-gwapi-again branch May 24, 2023 02:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants