Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add EnvoyPatchPolicy support in K8s provider #1624

Merged
merged 2 commits into from
Jul 5, 2023

Conversation

arkodg
Copy link
Contributor

@arkodg arkodg commented Jul 4, 2023

Relates to #24

@arkodg arkodg requested a review from a team as a code owner July 4, 2023 20:00
Signed-off-by: Arko Dasgupta <arko@tetrate.io>
@arkodg arkodg force-pushed the patchpolicy-provider branch from d2daf1d to e18c149 Compare July 4, 2023 20:01
@codecov
Copy link

codecov bot commented Jul 4, 2023

Codecov Report

Merging #1624 (8109f90) into main (3892d90) will decrease coverage by 0.10%.
The diff coverage is 13.04%.

@@            Coverage Diff             @@
##             main    #1624      +/-   ##
==========================================
- Coverage   61.41%   61.32%   -0.10%     
==========================================
  Files          81       81              
  Lines       12134    12157      +23     
==========================================
+ Hits         7452     7455       +3     
- Misses       4226     4243      +17     
- Partials      456      459       +3     
Impacted Files Coverage Δ
internal/gatewayapi/resource.go 50.00% <0.00%> (-1.52%) ⬇️
internal/gatewayapi/zz_generated.deepcopy.go 0.00% <0.00%> (ø)
internal/provider/kubernetes/controller.go 50.90% <23.07%> (-0.40%) ⬇️

@arkodg arkodg requested review from a team, zhaohuabing, qicz and Xunzhuo and removed request for a team July 4, 2023 20:21
Signed-off-by: Arko Dasgupta <arko@tetrate.io>
Copy link
Member

@zhaohuabing zhaohuabing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zirain zirain merged commit 3974be6 into envoyproxy:main Jul 5, 2023
@arkodg arkodg deleted the patchpolicy-provider branch July 5, 2023 02:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants