feat: support statsmatch from proxy metric #1826
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1826 +/- ##
==========================================
- Coverage 65.98% 65.97% -0.02%
==========================================
Files 86 86
Lines 12910 12924 +14
==========================================
+ Hits 8519 8526 +7
- Misses 3851 3857 +6
- Partials 540 541 +1
|
arkodg
reviewed
Aug 25, 2023
tmsnan
force-pushed
the
dev-add-stats-matcher-code
branch
from
abd2bbc
to
884d5da
Compare
arkodg
reviewed
Aug 28, 2023
arkodg
reviewed
Aug 28, 2023
arkodg
reviewed
Aug 28, 2023
zirain
reviewed
Sep 3, 2023
added 7 commits
September 4, 2023 19:04
Signed-off-by: zhaonan <zhaonan06@corp.netease.com>
Signed-off-by: zhaonan <zhaonan06@corp.netease.com>
Signed-off-by: zhaonan <zhaonan06@corp.netease.com>
Signed-off-by: zhaonan <zhaonan06@corp.netease.com>
Signed-off-by: zhaonan <zhaonan06@corp.netease.com>
tmsnan
force-pushed
the
dev-add-stats-matcher-code
branch
from
5cf1475
to
5f2ea0d
Compare
tmsnan
force-pushed
the
dev-add-stats-matcher-code
branch
from
5f2ea0d
to
545d686
Compare
|
/retest |
|
/retest |
|
blocked on #1877 |
arkodg
reviewed
Sep 12, 2023
| @@ -11,7 +11,12 @@ type ProxyMetrics struct { | |||
| // Sinks defines the metric sinks where metrics are sent to. | |||
| Sinks []MetricSink `json:"sinks,omitempty"` | |||
| // Matches defines configuration for selecting specific metrics instead of generating all metrics stats | |||
| // that are enabled by default. This helps reduce CPU and memory overhead in Envoy. | |||
| // that are enabled by default. This helps reduce CPU and memory overhead in Envoy, but eliminating some stats | |||
| // may after critical functionality. Here are the stats that we strongly recommend not disabling: | |||
Alice-Lilith
previously approved these changes
Sep 12, 2023
Signed-off-by: zhaonan <zhaonan06@corp.netease.com>
zirain
approved these changes
Sep 13, 2023
|
/retest |
1 similar comment
|
/retest |
arkodg
approved these changes
Sep 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
feat: support statsmatch from proxy metric.
Releate: #1669 #1761