fix(ci): whitenoise lint failed when pull request #1904
Conversation
zaunist
changed the title
zaunist
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1904 +/- ##
==========================================
- Coverage 64.59% 64.35% -0.24%
==========================================
Files 112 109 -3
Lines 16072 15302 -770
==========================================
- Hits 10382 9848 -534
+ Misses 5038 4845 -193
+ Partials 652 609 -43 ☔ View full report in Codecov by Sentry. |
Thanks for working on it, I did not look deep into this issue, but it seems like still throw an error in Pull Request. |
You're right, I'm not entirely sure about the exact problem either. This is my first test, and I will further study how to solve this issue carefully. |
|
Hi, @Xunzhuo. I've identified the issue. In the github pull request CI environment, there is no branch information available, causing the git diff command to fail. Therefore, I added a git fetch command to retrieve the remote branch information and prefixed the branch names with "origin" to match them. Here is my debug info for reference.
https://github.com/zaunist/gateway/actions/runs/6262614026/job/17005194717 |
|
/retest |
|
This pull request has been automatically marked as stale because it has not had activity in the last 30 days. Please feel free to give a status update now, ping for review, when it's ready. Thank you for your contributions! |
|
@zaunist DCO is failing, can you squash, sign and push again ? |
Done |
|
DCO is still failing, you might need to squash commits and then resign and push |
| @@ -1,7 +1,8 @@ | |||
| #!/bin/bash | |||
| TRAILING_WHITESPACE=0 | |||
| # only check changed docs in pr | |||
| for file in $(git diff --cached --name-only --diff-filter=ACRMTU $GITHUB_BASE_REF | grep "\.md"); do | |||
| git fetch | |||
| for file in $(git diff --cached --name-only --diff-filter=ACRMTU origin/$GITHUB_BASE_REF| grep "\.md"); do | |||
There was a problem hiding this comment.
thinking out loud, why isn't git diff --name-only good enough here ?
There was a problem hiding this comment.
The issue here is that the GitHub Actions environment does not have the branch information for Git, which causes an error when using git diff to compare the differences. To resolve this, I simply added a git fetch command to retrieve the branch information from the remote repository. For further debugging information, you can refer to this link: https://github.com/zaunist/gateway/actions/runs/6262614026/job/17005194717.
There was a problem hiding this comment.
@zaunist im suggesting removing the older command and replacing with something simpler git diff --name-only which doesnt require branch info, do you see any issue with this approach ?
There was a problem hiding this comment.
@arkodg If we don't provide branch information, how can we compare the differences between the fork and main branches? I'm not quite understanding this point. Could you provide an example, please?
Willing to make more contributions |
What type of PR is this?
Fix whitenoise lint error
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes 523