Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add rateLimit to BackendTrafficPolicy #2060

Merged
merged 4 commits into from
Oct 25, 2023

Conversation

arkodg
Copy link
Contributor

@arkodg arkodg commented Oct 24, 2023

Relates to #1821 & #2006

@arkodg arkodg requested a review from a team as a code owner October 24, 2023 22:46
@arkodg arkodg marked this pull request as draft October 24, 2023 22:46
@codecov
Copy link

codecov bot commented Oct 24, 2023

Codecov Report

Merging #2060 (488960e) into main (a00d289) will decrease coverage by 0.12%.
Report is 1 commits behind head on main.
The diff coverage is 62.41%.

@@            Coverage Diff             @@
##             main    #2060      +/-   ##
==========================================
- Coverage   65.17%   65.06%   -0.12%     
==========================================
  Files          99       99              
  Lines       14410    14536     +126     
==========================================
+ Hits         9392     9458      +66     
- Misses       4437     4491      +54     
- Partials      581      587       +6     
Files Coverage Δ
internal/gatewayapi/helpers.go 83.90% <100.00%> (+0.12%) ⬆️
internal/gatewayapi/translator.go 98.50% <100.00%> (ø)
internal/status/backendtrafficpolicy.go 0.00% <0.00%> (ø)
internal/gatewayapi/backendtrafficpolicy.go 64.53% <64.70%> (-4.14%) ⬇️

... and 3 files with indirect coverage changes

@arkodg arkodg marked this pull request as ready for review October 24, 2023 23:26
@zhaohuabing
Copy link
Member

zhaohuabing commented Oct 25, 2023

What happens if both a "RateLimitFilter" and the "RateLimit" of a "BackendTrafficPolicy" attach the same route? Will "RateLimitFilter" API be deprecated?

@arkodg
Copy link
Contributor Author

arkodg commented Oct 25, 2023

What happens if both a "RateLimitFilter" and the "RateLimit" of a "BackendTrafficPolicy" attach the same route? Will we deprecate "RateLimitFilter"?

@zhaohuabing the plan is to remove RateLimitFilter (& AuthenticationFilter) before we release v0.6

zirain
zirain previously approved these changes Oct 25, 2023
Relates to envoyproxy#1821 & envoyproxy#2006

Signed-off-by: Arko Dasgupta <arko@tetrate.io>
Signed-off-by: Arko Dasgupta <arko@tetrate.io>
Signed-off-by: Arko Dasgupta <arko@tetrate.io>
zirain
zirain previously approved these changes Oct 25, 2023
Signed-off-by: Arko Dasgupta <arko@tetrate.io>
@arkodg arkodg enabled auto-merge (squash) October 25, 2023 01:25
@arkodg arkodg merged commit e4d9d7e into envoyproxy:main Oct 25, 2023
18 checks passed
@arkodg arkodg deleted the rl-backend-traffic-policy branch October 25, 2023 01:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants