-
Notifications
You must be signed in to change notification settings - Fork 366
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add jwt authn to SecurityPolicy #2079
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhaohuabing
force-pushed
the
securitypolicy-jwt
branch
from
October 26, 2023 04:44
d3ae4a1
to
d9d3354
Compare
zhaohuabing
commented
Oct 26, 2023
zhaohuabing
force-pushed
the
securitypolicy-jwt
branch
4 times, most recently
from
October 26, 2023 05:57
bd4c47d
to
d05611d
Compare
Codecov Report
@@ Coverage Diff @@
## main #2079 +/- ##
==========================================
+ Coverage 64.32% 64.46% +0.14%
==========================================
Files 107 109 +2
Lines 14944 15299 +355
==========================================
+ Hits 9613 9863 +250
- Misses 4739 4820 +81
- Partials 592 616 +24
|
Signed-off-by: huabing zhao <zhaohuabing@gmail.com>
Signed-off-by: huabing zhao <zhaohuabing@gmail.com>
zhaohuabing
force-pushed
the
securitypolicy-jwt
branch
from
October 26, 2023 06:13
d05611d
to
be3d207
Compare
arkodg
approved these changes
Oct 26, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM thanks !
arkodg
requested review from
a team,
tmsnan,
Xunzhuo and
tanujd11
and removed request for
a team
October 26, 2023 19:12
zirain
approved these changes
Oct 26, 2023
This was referenced Nov 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
This PR adds JWT Authentication to the
SecurityPolicy
.Related issue: #1845
This feature is intended to replace the JWT Authn configuration in the existing
AuthenticationFilter
.AuthenticationFilter
will be removed in a follow-up PR.