Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add jwt authn to SecurityPolicy #2079

Merged
merged 3 commits into from
Oct 26, 2023

Conversation

zhaohuabing
Copy link
Member

@zhaohuabing zhaohuabing commented Oct 26, 2023

What type of PR is this?
This PR adds JWT Authentication to the SecurityPolicy.

Related issue: #1845

This feature is intended to replace the JWT Authn configuration in the existing AuthenticationFilter. AuthenticationFilter will be removed in a follow-up PR.

@zhaohuabing zhaohuabing requested a review from a team as a code owner October 26, 2023 04:43
@zhaohuabing zhaohuabing force-pushed the securitypolicy-jwt branch 4 times, most recently from bd4c47d to d05611d Compare October 26, 2023 05:57
@codecov
Copy link

codecov bot commented Oct 26, 2023

Codecov Report

Merging #2079 (be3d207) into main (6b8794e) will increase coverage by 0.14%.
The diff coverage is 72.86%.

@@            Coverage Diff             @@
##             main    #2079      +/-   ##
==========================================
+ Coverage   64.32%   64.46%   +0.14%     
==========================================
  Files         107      109       +2     
  Lines       14944    15299     +355     
==========================================
+ Hits         9613     9863     +250     
- Misses       4739     4820      +81     
- Partials      592      616      +24     
Files Coverage Δ
api/v1alpha1/validation/authenticationfilter.go 86.56% <ø> (ø)
internal/gatewayapi/securitypolicy.go 78.60% <100.00%> (+2.34%) ⬆️
internal/xds/translator/authentication.go 71.81% <75.00%> (-1.66%) ⬇️
internal/xds/translator/translator.go 79.51% <0.00%> (-0.84%) ⬇️
api/v1alpha1/validation/securitypolicy_validate.go 94.36% <94.36%> (ø)
internal/ir/xds.go 71.39% <45.45%> (-2.72%) ⬇️
internal/xds/translator/httpfilters.go 72.36% <25.00%> (-5.90%) ⬇️
internal/ir/zz_generated.deepcopy.go 11.72% <0.00%> (-0.25%) ⬇️
internal/xds/translator/jwt_authn.go 73.36% <73.36%> (ø)

... and 2 files with indirect coverage changes

@zhaohuabing zhaohuabing requested review from arkodg and zirain October 26, 2023 06:08
Signed-off-by: huabing zhao <zhaohuabing@gmail.com>
Signed-off-by: huabing zhao <zhaohuabing@gmail.com>
Signed-off-by: huabing zhao <zhaohuabing@gmail.com>
Copy link
Contributor

@arkodg arkodg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks !

@arkodg arkodg requested review from a team, tmsnan, Xunzhuo and tanujd11 and removed request for a team October 26, 2023 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants