Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix docker build warning #4389

Merged
merged 4 commits into from
Oct 8, 2024
Merged

Conversation

zirain
Copy link
Contributor

@zirain zirain commented Oct 5, 2024

 1 warning found (use docker --debug to expand):
 - FromAsCasing: 'as' and 'FROM' keywords' casing do not match (line 1)

@zirain zirain marked this pull request as ready for review October 5, 2024 08:05
@zirain zirain requested a review from a team as a code owner October 5, 2024 08:05
Copy link

codecov bot commented Oct 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 65.76%. Comparing base (8713185) to head (519d39e).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4389      +/-   ##
==========================================
+ Coverage   65.72%   65.76%   +0.04%     
==========================================
  Files         200      200              
  Lines       24125    24125              
==========================================
+ Hits        15855    15865      +10     
+ Misses       7137     7128       -9     
+ Partials     1133     1132       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

arkodg
arkodg previously approved these changes Oct 8, 2024
@arkodg arkodg requested review from a team October 8, 2024 01:11
Signed-off-by: zirain <zirain2009@gmail.com>
@shawnh2
Copy link
Contributor

shawnh2 commented Oct 8, 2024

/retest

@zirain zirain merged commit 2f67765 into envoyproxy:main Oct 8, 2024
23 checks passed
@zirain zirain deleted the dockerfile-nit branch October 8, 2024 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants