Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump google.golang.org/grpc v1.67 #4390

Merged
merged 4 commits into from
Oct 9, 2024
Merged

bump google.golang.org/grpc v1.67 #4390

merged 4 commits into from
Oct 9, 2024

Conversation

zirain
Copy link
Member

@zirain zirain commented Oct 5, 2024

related to grpc/grpc-go#7535

@zirain zirain marked this pull request as ready for review October 5, 2024 08:16
@zirain zirain requested a review from a team as a code owner October 5, 2024 08:16
Copy link

codecov bot commented Oct 5, 2024

Codecov Report

Attention: Patch coverage is 33.33333% with 2 lines in your changes missing coverage. Please review.

Project coverage is 65.73%. Comparing base (2f67765) to head (6749e76).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
internal/gatewayapi/runner/runner.go 0.00% 1 Missing ⚠️
internal/globalratelimit/runner/runner.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4390      +/-   ##
==========================================
+ Coverage   65.70%   65.73%   +0.03%     
==========================================
  Files         200      200              
  Lines       24125    24128       +3     
==========================================
+ Hits        15851    15861      +10     
+ Misses       7139     7135       -4     
+ Partials     1135     1132       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: zirain <zirain2009@gmail.com>
@zirain zirain changed the title bump google.golang.org/grpc v1.67.0 bump google.golang.org/grpc v1.67 Oct 7, 2024
Signed-off-by: zirain <zirain2009@gmail.com>
@arkodg
Copy link
Contributor

arkodg commented Oct 9, 2024

hey @zirain can you add more info on why we are pinning ALPN to h2 for all internal control plane communication and how it relates to the package bump ?

@zirain
Copy link
Member Author

zirain commented Oct 9, 2024

hey @zirain can you add more info on why we are pinning ALPN to h2 for all internal control plane communication and how it relates to the package bump ?

grpc/grpc-go#7535

@zirain
Copy link
Member Author

zirain commented Oct 9, 2024

License Scan will be fixed in #4414.

@zirain zirain merged commit 93a0561 into envoyproxy:main Oct 9, 2024
22 of 24 checks passed
@zirain zirain deleted the bump-grpc branch October 9, 2024 05:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants