Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: add standalone deployment doc #4518

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

shawnh2
Copy link
Contributor

@shawnh2 shawnh2 commented Oct 24, 2024

What type of PR is this?

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #1393

Release Notes: No

Signed-off-by: shawnh2 <shawnhxh@outlook.com>
Copy link

codecov bot commented Oct 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 65.53%. Comparing base (2c98617) to head (a73d014).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4518   +/-   ##
=======================================
  Coverage   65.53%   65.53%           
=======================================
  Files         211      211           
  Lines       31954    31954           
=======================================
+ Hits        20941    20942    +1     
+ Misses       9770     9768    -2     
- Partials     1243     1244    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: shawnh2 <shawnhxh@outlook.com>
@shawnh2 shawnh2 marked this pull request as ready for review October 26, 2024 13:50
@shawnh2 shawnh2 requested a review from a team as a code owner October 26, 2024 13:50
@shawnh2
Copy link
Contributor Author

shawnh2 commented Oct 26, 2024

wait #4535

@shawnh2 shawnh2 added documentation Improvements or additions to documentation hold do not merge area/standalone Issues related to the standalone mode and removed hold do not merge labels Oct 26, 2024
@shawnh2
Copy link
Contributor Author

shawnh2 commented Oct 27, 2024

/retest

spec:
endpoints:
- ip:
address: 0.0.0.0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we add a comment in the YAML saying 0.0.0.0 is only used for demo purposes, do not use this in a production environment

Envoy Gateway also supports running in standalone mode. In this mode, Envoy Gateway
does not need to rely on Kubernetes and can be deployed directly on bare metal or virtual machines.
In the standalone deployment mode, the functions and features supported by Envoy Gateway are
basically the same as those in the Kubernetes deployment mode.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

my suggestion would be to rm L13-14 or specifically specify which features will not work in standalone mode

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/standalone Issues related to the standalone mode documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Run Envoy Gateway locally on host
4 participants