Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: customize envoyproxy dualstack #4639

Merged
merged 3 commits into from
Dec 12, 2024
Merged

Conversation

juwon8891
Copy link
Contributor

@juwon8891 juwon8891 commented Nov 6, 2024

docs: customize envoyproxy dualstack

What's Changed

  • Added documentation for customizing EnvoyProxy IP family configuration
  • Added note about cluster requirements for DualStack networking

@juwon8891 juwon8891 requested a review from a team as a code owner November 6, 2024 02:34
@@ -1003,6 +1003,48 @@ spec:
{{% /tab %}}
{{< /tabpane >}}

## Customize EnvoyProxy IP Family

You can customize the IP family configuration for EnvoyProxy via the EnvoyProxy Config.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
You can customize the IP family configuration for EnvoyProxy via the EnvoyProxy Config.
You can customize the IP family configuration for EnvoyProxy via the EnvoyProxy Config.
This allows the Envoy Proxy fleet to serve external client over IPv4 as well as IPv6.
The below configuration sets the `ipFamily` to `DualStack` to allow ingressing IPv4 as well as IPv6 traffic.
**Note**: Envoy Gateway relies on the [Service](https://kubernetes.io/docs/concepts/services-networking/dual-stack/#services) spec of the BackendRef resource (linked to xRoutes) to decide which type of IP addresses to use to route to them.

@arkodg
Copy link
Contributor

arkodg commented Nov 7, 2024

thanks @juwon8891, added a comment
can you also update the same doc in v1.2/ and latest/

Copy link

codecov bot commented Nov 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 65.67%. Comparing base (e6d3526) to head (d9349be).
Report is 20 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4639      +/-   ##
==========================================
- Coverage   65.68%   65.67%   -0.01%     
==========================================
  Files         211      211              
  Lines       32064    32064              
==========================================
- Hits        21060    21057       -3     
- Misses       9761     9763       +2     
- Partials     1243     1244       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@arkodg
Copy link
Contributor

arkodg commented Dec 5, 2024

@juwon8891 can you address the CI failures

Signed-off-by: Juwon Hwang (Kevin) <juwon8891@gmail.com>
Signed-off-by: Juwon Hwang (Kevin) <juwon8891@gmail.com>
@juwon8891 juwon8891 force-pushed the docs/dualstack branch 2 times, most recently from 2eff351 to 836da55 Compare December 5, 2024 03:17
Signed-off-by: Juwon Hwang (Kevin) <juwon8891@gmail.com>
@juwon8891
Copy link
Contributor Author

@juwon8891 can you address the CI failures

I resolved problem!

@arkodg arkodg requested review from a team December 5, 2024 19:42
@zirain zirain merged commit a41f1f1 into envoyproxy:main Dec 12, 2024
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants