Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add a note of helm not updating CRDs in the upgrade section #4675

Merged
merged 2 commits into from
Nov 8, 2024

Conversation

arkodg
Copy link
Contributor

@arkodg arkodg commented Nov 7, 2024

No description provided.

Signed-off-by: Arko Dasgupta <arko@tetrate.io>
@arkodg arkodg requested a review from a team as a code owner November 7, 2024 22:25
@arkodg arkodg requested a review from a team November 7, 2024 22:25
@arkodg arkodg added the documentation Improvements or additions to documentation label Nov 7, 2024
Copy link

codecov bot commented Nov 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 65.56%. Comparing base (0017043) to head (78e03ef).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4675      +/-   ##
==========================================
- Coverage   65.57%   65.56%   -0.02%     
==========================================
  Files         211      211              
  Lines       31952    31952              
==========================================
- Hits        20952    20948       -4     
- Misses       9757     9760       +3     
- Partials     1243     1244       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Arko Dasgupta <arko@tetrate.io>
@zirain
Copy link
Member

zirain commented Nov 7, 2024

should consider add a new helm chart called gateway-crds-helm?

@arkodg
Copy link
Contributor Author

arkodg commented Nov 8, 2024

should consider add a new helm chart called gateway-crds-helm?

this being tracked with #4001

@arkodg arkodg requested a review from a team November 8, 2024 01:16
@zhaohuabing zhaohuabing merged commit 5d3df77 into envoyproxy:main Nov 8, 2024
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants