fix(ratelimiter): prevent REDIS_URL being overwritten if set #4722
+11
−8
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
fix(ratelimiter): prevent REDIS_URL from being overwritten if already set
What this PR does / why we need it:
This PR updates the logic to ensure that the REDIS_URL environment variable is only set if it isn’t already defined in the environment. This is especially important for when this issue is solved and proper Redis authentication is setup.
Example: I want to be able to set the REDIS_URL to a secret, which isn't possible in a configmap.
As of currently, not setting the
url
while havingrateLimit
set is putting Gateway in a crashloop.Which issue(s) this PR fixes:
Fixes #
Release Notes: No