Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

e2e: fix some tests #4729

Merged
merged 4 commits into from
Nov 19, 2024
Merged

e2e: fix some tests #4729

merged 4 commits into from
Nov 19, 2024

Conversation

zirain
Copy link
Member

@zirain zirain commented Nov 16, 2024

  1. prometheus address wrong on IPv6
  2. make E2E_TIMEOUT configurable
  3. skip EGUpgradeTest on IPv6

Signed-off-by: zirain <zirain2009@gmail.com>
@zirain zirain requested a review from a team as a code owner November 16, 2024 09:14
Copy link

codecov bot commented Nov 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 65.63%. Comparing base (97a5d68) to head (7899fdd).
Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4729      +/-   ##
==========================================
+ Coverage   65.58%   65.63%   +0.04%     
==========================================
  Files         211      211              
  Lines       31998    31998              
==========================================
+ Hits        20986    21002      +16     
+ Misses       9768     9758      -10     
+ Partials     1244     1238       -6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

Signed-off-by: zirain <zirain2009@gmail.com>
Signed-off-by: zirain <zirain2009@gmail.com>
@arkodg arkodg requested review from a team November 19, 2024 01:56
Copy link
Member

@zhaohuabing zhaohuabing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks!

@zirain zirain merged commit 8a01dd6 into envoyproxy:main Nov 19, 2024
24 checks passed
@zirain zirain deleted the e2e/prometheus branch November 19, 2024 07:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants