listen on ipv4 addresses by default #4817
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* listen on `::` if the listener IPFamily is `IPv6` or `DualStack` * Set `ipv4_compat` to `true` if `IPFamily` is `DualStack` Signed-off-by: Arko Dasgupta <arko@tetrate.io>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4817 +/- ##
=======================================
Coverage 65.60% 65.61%
=======================================
Files 211 211
Lines 31982 31999 +17
=======================================
+ Hits 20983 20997 +14
- Misses 9758 9760 +2
- Partials 1241 1242 +1 ☔ View full report in Codecov by Sentry. |
zirain
approved these changes
Nov 30, 2024
|
will this make ipv6 test failed without additional IPFamily in EnvoyProxy? |
Yes we'll need to explicitly set IPFamily in EnvoyProxy for the ipv6 test |
zhaohuabing
approved these changes
Nov 30, 2024
zhaohuabing
pushed a commit
to zhaohuabing/gateway
that referenced
this pull request
Nov 30, 2024
* listen on `::` if the listener IPFamily is `IPv6` or `DualStack` * Set `ipv4_compat` to `true` if `IPFamily` is `DualStack` Signed-off-by: Arko Dasgupta <arko@tetrate.io> (cherry picked from commit d1a8c47) Signed-off-by: Huabing Zhao <zhaohuabing@gmail.com>
zhaohuabing
added a commit
that referenced
this pull request
Nov 30, 2024
* xds: use IPv4Compat on ready server (#4798) Signed-off-by: zirain <zirain2009@gmail.com> (cherry picked from commit 9f9de74) Signed-off-by: Huabing Zhao <zhaohuabing@gmail.com> * xds: use `::1` if IPFamily is IPv6 on admin server (#4801) xds: use if IPFamily is IPv6 Signed-off-by: zirain <zirain2009@gmail.com> (cherry picked from commit 17e932c) Signed-off-by: Huabing Zhao <zhaohuabing@gmail.com> * listen on ipv4 addresses by default (#4817) * listen on `::` if the listener IPFamily is `IPv6` or `DualStack` * Set `ipv4_compat` to `true` if `IPFamily` is `DualStack` Signed-off-by: Arko Dasgupta <arko@tetrate.io> (cherry picked from commit d1a8c47) Signed-off-by: Huabing Zhao <zhaohuabing@gmail.com> --------- Signed-off-by: zirain <zirain2009@gmail.com> Signed-off-by: Huabing Zhao <zhaohuabing@gmail.com> Signed-off-by: Arko Dasgupta <arko@tetrate.io> Co-authored-by: zirain <zirain2009@gmail.com> Co-authored-by: Arko Dasgupta <arkodg@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
::if the listener IPFamily isIPv6orDualStackipv4_compattotrueifIPFamilyisDualStack