Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add test for file-provider #4864

Merged
merged 3 commits into from
Dec 23, 2024
Merged

test: add test for file-provider #4864

merged 3 commits into from
Dec 23, 2024

Conversation

shawnh2
Copy link
Contributor

@shawnh2 shawnh2 commented Dec 7, 2024

What type of PR is this?

What this PR does / why we need it:

follow-up of #4807

Which issue(s) this PR fixes:

Release Notes: No

@shawnh2 shawnh2 requested a review from a team as a code owner December 7, 2024 10:35
Signed-off-by: shawnh2 <shawnhxh@outlook.com>
Signed-off-by: shawnh2 <shawnhxh@outlook.com>
Copy link

codecov bot commented Dec 7, 2024

Codecov Report

Attention: Patch coverage is 74.19355% with 8 lines in your changes missing coverage. Please review.

Project coverage is 66.74%. Comparing base (ca2d80b) to head (2331d2c).
Report is 7 commits behind head on main.

Files with missing lines Patch % Lines
internal/provider/file/file.go 68.00% 4 Missing and 4 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4864      +/-   ##
==========================================
+ Coverage   66.29%   66.74%   +0.44%     
==========================================
  Files         209      209              
  Lines       32035    32052      +17     
==========================================
+ Hits        21239    21393     +154     
+ Misses       9536     9380     -156     
- Partials     1260     1279      +19     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@shawnh2
Copy link
Contributor Author

shawnh2 commented Dec 10, 2024

/retest

Copy link
Member

@zhaohuabing zhaohuabing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks!

@zirain zirain merged commit 4a64034 into envoyproxy:main Dec 23, 2024
21 of 22 checks passed
@shawnh2 shawnh2 deleted the fp-test branch December 23, 2024 02:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants