feat(translator): preserve route order in EnvoyProxy #4955
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4955 +/- ##
==========================================
+ Coverage 66.77% 66.83% +0.05%
==========================================
Files 209 209
Lines 32100 32112 +12
==========================================
+ Hits 21434 21461 +27
+ Misses 9379 9368 -11
+ Partials 1287 1283 -4 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Guy Daich <guy.daich@sap.com>
guydc
force-pushed
the
api-user-route-order
branch
from
389b43d to
b7f9f29
Compare
zhaohuabing
reviewed
Dec 31, 2024
|
CTP doesn't feel like the right place for this, imo this is a global setting that should live in either EnvoyProxy or EnvoyGateway |
Signed-off-by: Guy Daich <guy.daich@sap.com>
Signed-off-by: Guy Daich <guy.daich@sap.com>
Signed-off-by: Guy Daich <guy.daich@sap.com>
guydc
changed the title
arkodg
reviewed
Jan 6, 2025
arkodg
reviewed
Jan 6, 2025
Signed-off-by: Guy Daich <guy.daich@sap.com>
arkodg
approved these changes
Jan 7, 2025
cnvergence
approved these changes
Jan 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What this PR does / why we need it:
Add an option to
EnvoyProxyto preserve the user-defined route order.Which issue(s) this PR fixes:
Fixes #4943
Release Notes: Yes/No