-
Notifications
You must be signed in to change notification settings - Fork 392
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
api: support infra deployment in the gateway namespace #4982
Conversation
8385605
to
7a963e3
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4982 +/- ##
==========================================
- Coverage 66.75% 66.74% -0.01%
==========================================
Files 209 209
Lines 32058 32058
==========================================
- Hits 21399 21396 -3
- Misses 9381 9383 +2
- Partials 1278 1279 +1 ☔ View full report in Codecov by Sentry. |
c0d2e29
to
c22f4d6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM thanks !
Signed-off-by: Karol Szwaj <karol.szwaj@gmail.com>
Signed-off-by: Karol Szwaj <karol.szwaj@gmail.com>
Co-authored-by: Arko Dasgupta <arkodg@users.noreply.github.com> Signed-off-by: Karol Szwaj <karol.szwaj@gmail.com>
Co-authored-by: Arko Dasgupta <arkodg@users.noreply.github.com> Signed-off-by: Karol Szwaj <karol.szwaj@gmail.com>
Signed-off-by: Karol Szwaj <karol.szwaj@gmail.com>
Signed-off-by: Karol Szwaj <karol.szwaj@gmail.com>
3d0bd84
to
ce9e640
Compare
awesome!!! Thx !! |
What type of PR is this?
api: support infra deployment in the gateway namespace
What this PR does / why we need it:
api for supporting gateway namespace for envoy proxy infrastructure pods, there will be two modes, hoping that gateway-api proposal will pass in kubernetes-sigs/gateway-api#3366
This is the first part of #2629 issue
Which issue(s) this PR fixes:
Release Notes: No