Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

api: support infra deployment in the gateway namespace #4982

Merged
merged 6 commits into from
Jan 6, 2025

Conversation

cnvergence
Copy link
Member

@cnvergence cnvergence commented Dec 30, 2024

What type of PR is this?

api: support infra deployment in the gateway namespace

What this PR does / why we need it:

api for supporting gateway namespace for envoy proxy infrastructure pods, there will be two modes, hoping that gateway-api proposal will pass in kubernetes-sigs/gateway-api#3366

This is the first part of #2629 issue

Which issue(s) this PR fixes:

Release Notes: No

@cnvergence cnvergence force-pushed the support-infra-different-ns branch from 8385605 to 7a963e3 Compare December 30, 2024 17:58
Copy link

codecov bot commented Dec 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.74%. Comparing base (43621b4) to head (ce9e640).
Report is 7 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4982      +/-   ##
==========================================
- Coverage   66.75%   66.74%   -0.01%     
==========================================
  Files         209      209              
  Lines       32058    32058              
==========================================
- Hits        21399    21396       -3     
- Misses       9381     9383       +2     
- Partials     1278     1279       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cnvergence cnvergence force-pushed the support-infra-different-ns branch from c0d2e29 to c22f4d6 Compare December 31, 2024 17:54
@cnvergence cnvergence marked this pull request as ready for review December 31, 2024 17:54
@cnvergence cnvergence requested a review from a team as a code owner December 31, 2024 17:54
Copy link
Contributor

@arkodg arkodg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks !

@arkodg arkodg requested review from a team January 6, 2025 18:35
cnvergence and others added 6 commits January 7, 2025 04:34
Signed-off-by: Karol Szwaj <karol.szwaj@gmail.com>
Signed-off-by: Karol Szwaj <karol.szwaj@gmail.com>
Co-authored-by: Arko Dasgupta <arkodg@users.noreply.github.com>
Signed-off-by: Karol Szwaj <karol.szwaj@gmail.com>
Co-authored-by: Arko Dasgupta <arkodg@users.noreply.github.com>
Signed-off-by: Karol Szwaj <karol.szwaj@gmail.com>
Signed-off-by: Karol Szwaj <karol.szwaj@gmail.com>
Signed-off-by: Karol Szwaj <karol.szwaj@gmail.com>
@zirain zirain force-pushed the support-infra-different-ns branch from 3d0bd84 to ce9e640 Compare January 6, 2025 20:34
@arkodg arkodg merged commit 731d0d0 into envoyproxy:main Jan 6, 2025
25 checks passed
@cnvergence cnvergence deleted the support-infra-different-ns branch January 7, 2025 08:56
@kahirokunn
Copy link

awesome!!! Thx !!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants