Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

e2e: add test case for basic auth #5003

Merged
merged 2 commits into from
Jan 6, 2025
Merged

Conversation

zhaohuabing
Copy link
Member

What type of PR is this?

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Release Notes: Yes/No

@zhaohuabing zhaohuabing requested a review from a team as a code owner January 4, 2025 04:30
@zhaohuabing zhaohuabing marked this pull request as draft January 4, 2025 04:30
Copy link

codecov bot commented Jan 4, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.75%. Comparing base (10a31f1) to head (ef28ca4).
Report is 5 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5003      +/-   ##
==========================================
+ Coverage   66.71%   66.75%   +0.04%     
==========================================
  Files         209      209              
  Lines       32055    32055              
==========================================
+ Hits        21384    21397      +13     
+ Misses       9389     9380       -9     
+ Partials     1282     1278       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zhaohuabing zhaohuabing changed the title fix: basic auth chore: add test case for basic auth Jan 4, 2025
Signed-off-by: Huabing Zhao <zhaohuabing@gmail.com>
@zhaohuabing zhaohuabing marked this pull request as ready for review January 4, 2025 05:38
@zirain zirain changed the title chore: add test case for basic auth e2e: add test case for basic auth Jan 4, 2025
@zirain
Copy link
Member

zirain commented Jan 4, 2025

/retest

@arkodg arkodg requested review from a team January 6, 2025 20:26
@zirain zirain merged commit a6bcc1b into envoyproxy:main Jan 6, 2025
22 checks passed
@zhaohuabing zhaohuabing deleted the fix-basic-auth branch January 8, 2025 07:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants