feat(translator): support ext-proc dynamic metadata options #5023
+334
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5023 +/- ##
==========================================
- Coverage 66.77% 66.71% -0.07%
==========================================
Files 209 209
Lines 32383 32409 +26
==========================================
- Hits 21625 21622 -3
- Misses 9458 9479 +21
- Partials 1300 1308 +8 ☔ View full report in Codecov by Sentry. |
arkodg
reviewed
Jan 8, 2025
api/v1alpha1/ext_proc_types.go
Outdated
| // Default: no metadata context is sent or received from the external processor | ||
| // | ||
| // +optional | ||
| MetadataOptions *ExtProcMetadataOptions `json:"metadataOptions,omitempty"` |
arkodg
reviewed
Jan 8, 2025
api/v1alpha1/ext_proc_types.go
Outdated
| // metadata namespaces forwarded to external processor | ||
| // | ||
| // +optional | ||
| ForwardingNamespaces []string `json:"forwardingNamespaces,omitempty"` |
There was a problem hiding this comment.
some options from ChatGPT
Field for Reading Field for Writing
readNamespaces writeNamespaces
inputNamespaces outputNamespaces
sourceNamespaces targetNamespaces
namespacesForRead namespacesForWrite
accessibleNamespaces writableNamespaces
I like readNamespaces / writeNamespaces and accessibleNamespaces/writableNamespaces
guydc
force-pushed
the
feat-extproc-metadata
branch
from
1b9195a to
51a3df4
Compare
arkodg
reviewed
Jan 9, 2025
Signed-off-by: Guy Daich <guy.daich@sap.com>
Signed-off-by: Guy Daich <guy.daich@sap.com>
Signed-off-by: Guy Daich <guy.daich@sap.com>
Signed-off-by: Guy Daich <guy.daich@sap.com>
zirain
force-pushed
the
feat-extproc-metadata
branch
from
7950ffd to
5c7fb9c
Compare
zirain
approved these changes
Jan 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #3170, #4160
Release Notes: Yes