Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translation: return 500 when CTP translation fails #5030

Merged
merged 6 commits into from
Jan 14, 2025

Conversation

zhaohuabing
Copy link
Member

@zhaohuabing zhaohuabing commented Jan 10, 2025

  • Return a 503 response when a ClientTrafficPolicy translation fails for HTTP/GRPC routes.
  • Route client traffic to an empty dummy cluster when a ClientTrafficPolicy translation fails for TCP routes.

Implements: #4153
Release Notes: Yes

@zhaohuabing zhaohuabing requested a review from a team as a code owner January 10, 2025 09:03
@zhaohuabing zhaohuabing marked this pull request as draft January 10, 2025 09:03
Copy link

codecov bot commented Jan 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.82%. Comparing base (00ed0b8) to head (8c1b088).
Report is 11 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5030      +/-   ##
==========================================
+ Coverage   66.75%   66.82%   +0.06%     
==========================================
  Files         209      209              
  Lines       32409    32417       +8     
==========================================
+ Hits        21636    21663      +27     
+ Misses       9468     9452      -16     
+ Partials     1305     1302       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zhaohuabing zhaohuabing changed the title return 500 when CTP translation fails Translation: return 500 when CTP translation fails Jan 10, 2025
Signed-off-by: Huabing Zhao <zhaohuabing@gmail.com>
Signed-off-by: Huabing Zhao <zhaohuabing@gmail.com>
Signed-off-by: Huabing Zhao <zhaohuabing@gmail.com>
Signed-off-by: Huabing Zhao <zhaohuabing@gmail.com>
@zhaohuabing zhaohuabing marked this pull request as ready for review January 13, 2025 01:45

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
Signed-off-by: Huabing Zhao <zhaohuabing@gmail.com>

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
Signed-off-by: Huabing Zhao <zhaohuabing@gmail.com>
@zhaohuabing zhaohuabing requested a review from shawnh2 January 13, 2025 08:32
Copy link
Contributor

@arkodg arkodg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks !

@arkodg arkodg requested review from a team January 14, 2025 19:15
@arkodg arkodg merged commit 6327ca9 into envoyproxy:main Jan 14, 2025
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants