Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: show API default value #5031

Merged
merged 1 commit into from
Jan 11, 2025
Merged

Conversation

zirain
Copy link
Member

@zirain zirain commented Jan 10, 2025

fixes: #5028

only support maker like // +kubebuilder:default=1024

@zirain zirain requested a review from a team as a code owner January 10, 2025 10:22
Copy link

codecov bot commented Jan 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.81%. Comparing base (9cbdded) to head (6f76e60).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5031      +/-   ##
==========================================
+ Coverage   66.78%   66.81%   +0.03%     
==========================================
  Files         209      209              
  Lines       32409    32409              
==========================================
+ Hits        21645    21655      +10     
+ Misses       9460     9454       -6     
+ Partials     1304     1300       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

arkodg
arkodg previously approved these changes Jan 10, 2025
Copy link
Contributor

@arkodg arkodg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks !

@arkodg arkodg requested review from a team January 10, 2025 19:12
@zirain zirain force-pushed the api-doc/show-defaults branch from ba158f3 to 1427709 Compare January 11, 2025 02:26
Signed-off-by: zirain <zirain2009@gmail.com>
@zirain zirain force-pushed the api-doc/show-defaults branch from 1427709 to 6f76e60 Compare January 11, 2025 02:58
@zirain zirain requested a review from arkodg January 11, 2025 05:27
@zirain zirain merged commit 00ed0b8 into envoyproxy:main Jan 11, 2025
28 checks passed
@zirain zirain deleted the api-doc/show-defaults branch January 11, 2025 08:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

docs: add a column to show defaults in API docs
3 participants