Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: version URL and image support baseURL #5037

Merged
merged 3 commits into from
Jan 14, 2025

Conversation

zirain
Copy link
Member

@zirain zirain commented Jan 13, 2025

this make it possible to change baseURL to any value in hugo.toml.

@zirain zirain requested a review from a team as a code owner January 13, 2025 01:38
Copy link

codecov bot commented Jan 13, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.74%. Comparing base (58a9b23) to head (f499d89).
Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5037      +/-   ##
==========================================
+ Coverage   66.67%   66.74%   +0.07%     
==========================================
  Files         210      210              
  Lines       32647    32647              
==========================================
+ Hits        21767    21791      +24     
+ Misses       9560     9544      -16     
+ Partials     1320     1312       -8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@arkodg
Copy link
Contributor

arkodg commented Jan 13, 2025

hey @zirain can you elaborate a little more on the benefit of this PR

@zirain
Copy link
Member Author

zirain commented Jan 13, 2025

this enable support for baseURL like https://example.com/subproject.

@arkodg
Copy link
Contributor

arkodg commented Jan 13, 2025

ah thanks
cc @missBerg

Signed-off-by: zirain <zirain2009@gmail.com>
Signed-off-by: zirain <zirain2009@gmail.com>
fix
Signed-off-by: zirain <zirain2009@gmail.com>
@zirain zirain merged commit 213f2e6 into envoyproxy:main Jan 14, 2025
28 checks passed
@zirain zirain deleted the docs/baseURL branch January 14, 2025 01:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants