feat(certgen): add flag for certificate overwrite #5045
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Guy Daich <guy.daich@sap.com>
guydc
force-pushed
the
feat-certgen-overwrite-flag
branch
from
ec110d0 to
8ed7638
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5045 +/- ##
==========================================
- Coverage 66.85% 66.81% -0.05%
==========================================
Files 211 211
Lines 32916 32920 +4
==========================================
- Hits 22007 21994 -13
- Misses 9584 9597 +13
- Partials 1325 1329 +4 ☔ View full report in Codecov by Sentry. |
arkodg
reviewed
Jan 13, 2025
arkodg
reviewed
Jan 13, 2025
| @@ -21,8 +21,12 @@ spec: | |||
| spec: | |||
| containers: | |||
| - command: | |||
| {{- if .Values.certgen.job.command }} | |||
| {{- toYaml .Values.certgen.job.command | nindent 8 }} | |||
Signed-off-by: Guy Daich <guy.daich@sap.com>
arkodg
reviewed
Jan 13, 2025
charts/gateway-helm/values.tmpl.yaml
Outdated
| @@ -92,6 +92,8 @@ kubernetesClusterDomain: cluster.local | |||
| certgen: | |||
| job: | |||
| annotations: {} | |||
| args: [] | |||
| command: [] | |||
Signed-off-by: Guy Daich <guy.daich@sap.com>
arkodg
reviewed
Jan 14, 2025
| @@ -544,7 +544,8 @@ spec: | |||
| app: certgen | |||
| spec: | |||
| containers: | |||
| - command: | |||
| - args: | |||
There was a problem hiding this comment.
args should not be set by default
Signed-off-by: Guy Daich <guy.daich@sap.com>
Signed-off-by: Guy Daich <guy.daich@sap.com>
Signed-off-by: Guy Daich <guy.daich@sap.com>
zirain
approved these changes
Jan 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #4935
Release Notes: Yes