Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

e2e: fix trusted cidr e2e tests for ipv6 #5067

Merged
merged 1 commit into from
Jan 15, 2025
Merged

e2e: fix trusted cidr e2e tests for ipv6 #5067

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions test/e2e/testdata/authorization-client-ip-trusted-cidrs.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,8 +45,9 @@
clientIPDetection:
xForwardedFor:
trustedCIDRs:
- "172.16.0.0/12"
- "10.0.1.0/24"
- "172.0.0.0/8"
- "10.0.0.0/8"
- "::/0" # trust all IPv6 addresses for E2E

Check warning on line 50 in test/e2e/testdata/authorization-client-ip-trusted-cidrs.yaml

View workflow job for this annotation

GitHub Actions / lint 

50:16 [comments] too few spaces before comment

Check warning on line 50 in test/e2e/testdata/authorization-client-ip-trusted-cidrs.yaml

View workflow job for this annotation

GitHub Actions / lint 

50:16 [comments] too few spaces before comment
targetRefs:
- group: gateway.networking.k8s.io
kind: Gateway
Expand Down
3 changes: 1 addition & 2 deletions test/e2e/tests/authorization_client_ip.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,8 +23,7 @@ import (

func init() {
ConformanceTests = append(ConformanceTests, AuthorizationClientIPTest)
// Uncomment once https://github.com/envoyproxy/gateway/issues/5063 is fixed
// ConformanceTests = append(ConformanceTests, AuthorizationClientIPTrustedCidrsTest)
ConformanceTests = append(ConformanceTests, AuthorizationClientIPTrustedCidrsTest)
}

var AuthorizationClientIPTest = suite.ConformanceTest{
Expand Down
Loading