feat(extension-manager): make grpc message size configurable #5077
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zirain
reviewed
Jan 16, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5077 +/- ##
==========================================
+ Coverage 66.87% 66.98% +0.10%
==========================================
Files 210 210
Lines 32951 32961 +10
==========================================
+ Hits 22037 22079 +42
+ Misses 9584 9554 -30
+ Partials 1330 1328 -2 ☔ View full report in Codecov by Sentry. |
zirain
previously approved these changes
Jan 16, 2025
arkodg
reviewed
Jan 16, 2025
api/v1alpha1/envoygateway_types.go
Outdated
| // +kubebuilder:validation:Minimum=1 | ||
| // | ||
| // +optional | ||
| MaxMessageSizeBytes *int `json:"grpcMaxMessageSize,omitempty"` |
There was a problem hiding this comment.
the json tag is different from the field name
also, can you check if we use the bytes suffix in other places of the API (e.g. buffer limit) or is it implied and part of the doc string ? would be good to keep it consistent
arkodg
reviewed
Jan 18, 2025
api/v1alpha1/envoygateway_types.go
Outdated
| // +kubebuilder:validation:Minimum=1 | ||
| // | ||
| // +optional | ||
| MaxMessageSize *int `json:"maxMessageSize,omitempty"` |
There was a problem hiding this comment.
should we use resource.Quantity here similar to
gateway/api/v1alpha1/connection_types.go
Line 28 in 0ee0a8a
zirain
approved these changes
Jan 21, 2025
Signed-off-by: Guy Daich <guy.daich@sap.com>
Signed-off-by: Guy Daich <guy.daich@sap.com>
Signed-off-by: Guy Daich <guy.daich@sap.com>
Signed-off-by: Guy Daich <guy.daich@sap.com>
zirain
force-pushed
the
feat-extmanager-grpc-msg-size
branch
from
c07b4a5 to
d7b73d5
Compare
EshaanAgg
pushed a commit
to EshaanAgg/gateway
that referenced
this pull request
Jan 22, 2025
…oxy#5077) * feat(extension-manager): make grpc message size configurable Signed-off-by: Guy Daich <guy.daich@sap.com> Signed-off-by: EshaanAgg <96648934+EshaanAgg@users.noreply.github.com>
DeeBi9
pushed a commit
to DeeBi9/gateway
that referenced
this pull request
Jan 25, 2025
…oxy#5077) * feat(extension-manager): make grpc message size configurable Signed-off-by: Guy Daich <guy.daich@sap.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #5075
Release Notes: Yes