feat(translator): use SDS to deliver system trust store to support dynamic reload #5084
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Guy Daich <guy.daich@sap.com>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5084 +/- ##
==========================================
- Coverage 66.92% 66.83% -0.09%
==========================================
Files 210 210
Lines 32995 32979 -16
==========================================
- Hits 22081 22041 -40
- Misses 9579 9596 +17
- Partials 1335 1342 +7 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Guy Daich <guy.daich@sap.com>
arkodg
previously approved these changes
Jan 17, 2025
Signed-off-by: Guy Daich <guy.daich@sap.com>
|
cc @arkodg |
arkodg
previously approved these changes
Jan 23, 2025
Signed-off-by: Guy Daich <guy.daich@sap.com>
Signed-off-by: Guy Daich <guy.daich@sap.com>
arkodg
reviewed
Jan 23, 2025
| @@ -44,6 +44,34 @@ var BackendTLSTest = suite.ConformanceTest{ | |||
| http.MakeRequestAndExpectEventuallyConsistentResponse(t, suite.RoundTripper, suite.TimeoutConfig, gwAddr, expectedResponse) | |||
| }) | |||
|
|
|||
| t.Run("with a backend TLS Policy using Truststore", func(t *testing.T) { | |||
| // the upstream used is the eg site which doesn't support IPv6 at this time | |||
| if IPFamily == "ipv6" { | |||
arkodg
approved these changes
Jan 23, 2025
DeeBi9
pushed a commit
to DeeBi9/gateway
that referenced
this pull request
Jan 25, 2025
…namic reload (envoyproxy#5084) * use SDS to deliver system trust store Signed-off-by: Guy Daich <guy.daich@sap.com> * fix manifests Signed-off-by: Guy Daich <guy.daich@sap.com> * skip test for IPv6 as target doesn't support it Signed-off-by: Guy Daich <guy.daich@sap.com> --------- Signed-off-by: Guy Daich <guy.daich@sap.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #5074
Release Notes: Yes