-
Notifications
You must be signed in to change notification settings - Fork 392
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(translator): check for default FC existence before clearing it on… #5121
Conversation
… error Signed-off-by: Guy Daich <guy.daich@sap.com>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5121 +/- ##
==========================================
- Coverage 66.89% 66.89% -0.01%
==========================================
Files 210 210
Lines 32977 32978 +1
==========================================
- Hits 22061 22059 -2
Misses 9583 9583
- Partials 1333 1336 +3 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
f522406
to
ac01f74
Compare
Signed-off-by: Guy Daich <guy.daich@sap.com>
ac01f74
to
90bfd37
Compare
envoyproxy#5121) * fix(translator): check for default FC existence before clearing it on error Signed-off-by: Guy Daich <guy.daich@sap.com> * add unit test Signed-off-by: Guy Daich <guy.daich@sap.com> --------- Signed-off-by: Guy Daich <guy.daich@sap.com>
What type of PR is this?
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #5119
Release Notes: No