Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fail validation if baseInterval is 0s #5176

Merged
merged 2 commits into from
Jan 30, 2025
Merged

fail validation if baseInterval is 0s #5176

merged 2 commits into from
Jan 30, 2025
+280 −14

Conversation

arkodg
Copy link
Contributor

@arkodg arkodg commented Jan 30, 2025

Fixes: #5147

@arkodg arkodg requested a review from a team as a code owner January 30, 2025 20:21
@arkodg arkodg added this to the v1.3.0 milestone Jan 30, 2025
@arkodg arkodg requested a review from a team January 30, 2025 20:21
@arkodg
fail validation if baseInterval is 0s
98f4ce7 
Fixes: envoyproxy#5147

Signed-off-by: Arko Dasgupta <arko@tetrate.io>
@arkodg arkodg force-pushed the cel-base-interval branch from d84819d to 98f4ce7 Compare January 30, 2025 21:19
@arkodg arkodg changed the title Add CEL Validation to disallow 0s for baseInterval fail validation if baseInterval is 0s Jan 30, 2025
guydc
guydc previously approved these changes Jan 30, 2025
View reviewed changes
@codecov Codecov
Copy link

codecov bot commented Jan 30, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 62.50000% with 9 lines in your changes missing coverage. Please review.

Project coverage is 66.81%. Comparing base (e904d3f) to head (5d08c17).
Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
internal/gatewayapi/clustersettings.go 66.66% 4 Missing and 2 partials ⚠️
internal/gatewayapi/backendtrafficpolicy.go 50.00% 2 Missing and 1 partial ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #5176      +/-   ##
==========================================
- Coverage   66.89%   66.81%   -0.09%     
==========================================
  Files         210      210              
  Lines       32979    32988       +9     
==========================================
- Hits        22061    22040      -21     
- Misses       9581     9603      +22     
- Partials     1337     1345       +8

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@arkodg
more validations
5d08c17 
Signed-off-by: Arko Dasgupta <arko@tetrate.io>
@arkodg arkodg requested a review from guydc January 30, 2025 21:35
@arkodg arkodg merged commit 4844d9a into envoyproxy:main Jan 30, 2025
25 checks passed
@arkodg arkodg deleted the cel-base-interval branch January 30, 2025 22:15
guydc pushed a commit to guydc/gateway that referenced this pull request Jan 31, 2025
@arkodg @guydc
fail validation if baseInterval is 0s (envoyproxy#5176)
3c15914 
* fail validation if baseInterval is 0s

Fixes: envoyproxy#5147

Signed-off-by: Arko Dasgupta <arko@tetrate.io>

* more validations

Signed-off-by: Arko Dasgupta <arko@tetrate.io>

---------

Signed-off-by: Arko Dasgupta <arko@tetrate.io>
guydc pushed a commit to guydc/gateway that referenced this pull request Jan 31, 2025
@arkodg @guydc
fail validation if baseInterval is 0s (envoyproxy#5176)
9c04aaa 
* fail validation if baseInterval is 0s

Fixes: envoyproxy#5147

Signed-off-by: Arko Dasgupta <arko@tetrate.io>

* more validations

Signed-off-by: Arko Dasgupta <arko@tetrate.io>

---------

Signed-off-by: Arko Dasgupta <arko@tetrate.io>
guydc pushed a commit to guydc/gateway that referenced this pull request Jan 31, 2025
@arkodg @guydc
fail validation if baseInterval is 0s (envoyproxy#5176)
0edc458 
* fail validation if baseInterval is 0s

Fixes: envoyproxy#5147

Signed-off-by: Arko Dasgupta <arko@tetrate.io>

* more validations

Signed-off-by: Arko Dasgupta <arko@tetrate.io>

---------

Signed-off-by: Arko Dasgupta <arko@tetrate.io>
guydc pushed a commit to guydc/gateway that referenced this pull request Jan 31, 2025
@arkodg @guydc
fail validation if baseInterval is 0s (envoyproxy#5176)
03f8300 
* fail validation if baseInterval is 0s

Fixes: envoyproxy#5147

Signed-off-by: Arko Dasgupta <arko@tetrate.io>

* more validations

Signed-off-by: Arko Dasgupta <arko@tetrate.io>

---------

Signed-off-by: Arko Dasgupta <arko@tetrate.io>
(cherry picked from commit 4844d9a)
Signed-off-by: Guy Daich <guy.daich@sap.com>
guydc pushed a commit to guydc/gateway that referenced this pull request Jan 31, 2025
@arkodg @guydc
fail validation if baseInterval is 0s (envoyproxy#5176)
280e8e0 
* fail validation if baseInterval is 0s

Fixes: envoyproxy#5147

Signed-off-by: Arko Dasgupta <arko@tetrate.io>

* more validations

Signed-off-by: Arko Dasgupta <arko@tetrate.io>

---------

Signed-off-by: Arko Dasgupta <arko@tetrate.io>
(cherry picked from commit 4844d9a)
Signed-off-by: Guy Daich <guy.daich@sap.com>
guydc pushed a commit to guydc/gateway that referenced this pull request Jan 31, 2025
@arkodg @guydc
fail validation if baseInterval is 0s (envoyproxy#5176)
fa48419 
* fail validation if baseInterval is 0s

Fixes: envoyproxy#5147

Signed-off-by: Arko Dasgupta <arko@tetrate.io>

* more validations

Signed-off-by: Arko Dasgupta <arko@tetrate.io>

---------

Signed-off-by: Arko Dasgupta <arko@tetrate.io>
(cherry picked from commit 4844d9a)
Signed-off-by: Guy Daich <guy.daich@sap.com>
guydc added a commit that referenced this pull request Jan 31, 2025
@guydc @zhaohuabing
@nothinux @arkodg @dependabot @shahar-h @dshatokhin @DeeBi9
[release/v1.3] release v1.3.0 cherry-pick from main (#5179)
76e714e 
* doc: response compression (#5071)

compression docs

Signed-off-by: Huabing Zhao <zhaohuabing@gmail.com>
(cherry picked from commit 549fdde)
Signed-off-by: Guy Daich <guy.daich@sap.com>

* docs: how to specify a self-signed ca for the remote jwks host in the SP JWT settings. (#5085)

* docs for jwt self-signed ca

Signed-off-by: Huabing Zhao <zhaohuabing@gmail.com>

* fix gen

Signed-off-by: Huabing Zhao <zhaohuabing@gmail.com>

* update docs

Signed-off-by: Huabing Zhao <zhaohuabing@gmail.com>

---------

Signed-off-by: Huabing Zhao <zhaohuabing@gmail.com>
(cherry picked from commit fdc7849)
Signed-off-by: Guy Daich <guy.daich@sap.com>

* chore: fix gen (#5166)

fix gen

Signed-off-by: Huabing (Robin) Zhao <zhaohuabing@gmail.com>
(cherry picked from commit 34db8af)
Signed-off-by: Guy Daich <guy.daich@sap.com>

* docs: add api key auth instructions (#5097)

* docs: add api key auth instruction

Signed-off-by: Taufik Mulyana <nothinux@gmail.com>

* fix: remove unrelated links

Signed-off-by: Taufik Mulyana <nothinux@gmail.com>

---------

Signed-off-by: Taufik Mulyana <nothinux@gmail.com>
(cherry picked from commit b5cf087)
Signed-off-by: Guy Daich <guy.daich@sap.com>

* add SECURITY.md (#5167)

Signed-off-by: Arko Dasgupta <arko@tetrate.io>
(cherry picked from commit f7a10eb)
Signed-off-by: Guy Daich <guy.daich@sap.com>

* chore: link SECURITY.md (#5168)

Signed-off-by: Arko Dasgupta <arko@tetrate.io>
(cherry picked from commit ac9026f)
Signed-off-by: Guy Daich <guy.daich@sap.com>

* build(deps): bump actions/stale from 9.0.0 to 9.1.0 (#5162)

Bumps [actions/stale](https://github.com/actions/stale) from 9.0.0 to 9.1.0.
- [Release notes](https://github.com/actions/stale/releases)
- [Changelog](https://github.com/actions/stale/blob/main/CHANGELOG.md)
- [Commits](actions/stale@28ca103...5bef64f)

---
updated-dependencies:
- dependency-name: actions/stale
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Arko Dasgupta <arkodg@users.noreply.github.com>
(cherry picked from commit 57d4aa8)
Signed-off-by: Guy Daich <guy.daich@sap.com>

* docs: rm sectionName from some of the examples (#5173)

adds whats left off from #4868

deleted the sectionName in these examples because the Service spec does
not define a port `Name`

Signed-off-by: Arko Dasgupta <arko@tetrate.io>
(cherry picked from commit 45804e2)
Signed-off-by: Guy Daich <guy.daich@sap.com>

* ci(fix): osv-scanner PR mode (#5174)

fix: osv-scanner PR mode

Signed-off-by: shahar-h <shahar.harari@sap.com>
Co-authored-by: Guy Daich <guy.daich@sap.com>
(cherry picked from commit e904d3f)
Signed-off-by: Guy Daich <guy.daich@sap.com>

* wip: docs: add standalone in container instruction (#5172)

* docs: add standalone in container instruction

Signed-off-by: Denis Shatokhin <d_shatokhin@outlook.com>

* docs: update headings and image tag

Signed-off-by: Denis Shatokhin <d_shatokhin@outlook.com>

---------

Signed-off-by: Denis Shatokhin <d_shatokhin@outlook.com>
(cherry picked from commit a3448c1)
Signed-off-by: Guy Daich <guy.daich@sap.com>

* docs: update prerequisites files with installation and connectivity t… (#5094)

* docs: update prerequisites files with installation and connectivity testing steps

Signed-off-by: DeeBi9 <deepanshudb1@gmail.com>

* lint

Signed-off-by: DeeBi9 <deepanshudb1@gmail.com>

* docs: remove the Note

Signed-off-by: DeeBi9 <deepanshudb1@gmail.com>

* remove redundant code

Signed-off-by: DeeBi9 <deepanshudb1@gmail.com>

---------

Signed-off-by: DeeBi9 <deepanshudb1@gmail.com>
(cherry picked from commit 3253339)
Signed-off-by: Guy Daich <guy.daich@sap.com>

* [release/v1.3] fix 1.3.0-rc.1 release note (#5175)

* fix 1.3.0-rc.1 release note

Signed-off-by: Guy Daich <guy.daich@sap.com>

* more fixes

Signed-off-by: Guy Daich <guy.daich@sap.com>

---------

Signed-off-by: Guy Daich <guy.daich@sap.com>
(cherry picked from commit 4fba2bf)
Signed-off-by: Guy Daich <guy.daich@sap.com>

* fail validation if baseInterval is 0s (#5176)

* fail validation if baseInterval is 0s

Fixes: #5147

Signed-off-by: Arko Dasgupta <arko@tetrate.io>

* more validations

Signed-off-by: Arko Dasgupta <arko@tetrate.io>

---------

Signed-off-by: Arko Dasgupta <arko@tetrate.io>
(cherry picked from commit 4844d9a)
Signed-off-by: Guy Daich <guy.daich@sap.com>

* [release/1.3] release notes (#5177)

Signed-off-by: Guy Daich <guy.daich@sap.com>
(cherry picked from commit c2215b2)
Signed-off-by: Guy Daich <guy.daich@sap.com>

---------

Signed-off-by: Huabing Zhao <zhaohuabing@gmail.com>
Signed-off-by: Guy Daich <guy.daich@sap.com>
Signed-off-by: Huabing (Robin) Zhao <zhaohuabing@gmail.com>
Signed-off-by: Taufik Mulyana <nothinux@gmail.com>
Signed-off-by: Arko Dasgupta <arko@tetrate.io>
Signed-off-by: dependabot[bot] <support@github.com>
Signed-off-by: shahar-h <shahar.harari@sap.com>
Signed-off-by: Denis Shatokhin <d_shatokhin@outlook.com>
Signed-off-by: DeeBi9 <deepanshudb1@gmail.com>
Co-authored-by: Huabing (Robin) Zhao <zhaohuabing@gmail.com>
Co-authored-by: Taufik Mulyana <17433202+nothinux@users.noreply.github.com>
Co-authored-by: Arko Dasgupta <arkodg@users.noreply.github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: shahar-h <shahar.harari@sap.com>
Co-authored-by: Denis Shatokhin <d_shatokhin@outlook.com>
Co-authored-by: Deepanshu Bisht <113498676+DeeBi9@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@guydc guydc guydc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.3.0
Development

Successfully merging this pull request may close these issues.

Mistake in a BackendTrafficPolicy causes all routes to return 404
2 participants
@arkodg @guydc