add client packages #5206
Open
add client packages #5206
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5206 +/- ##
==========================================
+ Coverage 66.87% 66.89% +0.01%
==========================================
Files 210 201 -9
Lines 32998 32980 -18
==========================================
- Hits 22067 22061 -6
+ Misses 9592 9582 -10
+ Partials 1339 1337 -2 ☔ View full report in Codecov by Sentry. |
dprotaso
force-pushed
the
add-client-packages
branch
from
dd697e0 to
13bb812
Compare
|
repushed commits for DCO |
|
Don't really understand the failure given this PR doesn't touch that package |
Signed-off-by: Dave Protasowski <dprotaso@gmail.com>
Signed-off-by: Dave Protasowski <dprotaso@gmail.com>
Signed-off-by: Dave Protasowski <dprotaso@gmail.com>
Signed-off-by: Dave Protasowski <dprotaso@gmail.com>
Signed-off-by: Dave Protasowski <dprotaso@gmail.com>
Signed-off-by: Dave Protasowski <dprotaso@gmail.com>
Signed-off-by: Dave Protasowski <dprotaso@gmail.com>
dprotaso
force-pushed
the
add-client-packages
branch
from
13bb812 to
54a26d3
Compare
|
rebased on latest main |
arkodg
reviewed
Feb 5, 2025
arkodg
reviewed
Feb 5, 2025
|
gotta sign |
Signed-off-by: Dave Protasowski <dprotaso@gmail.com>
Signed-off-by: Dave Protasowski <dprotaso@gmail.com>
dprotaso
force-pushed
the
add-client-packages
branch
from
c320541 to
9a4e5ca
Compare
|
thanks @dprotaso this PR looks good, would ideally like to have not have the patch committed, lets wait a day to see if kubernetes/kubernetes#129307 gets merged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commits
What type of PR is this?
What this PR does / why we need it:
This adds client sets allowing end-users to create envoy gateway resources programmatically.
Which issue(s) this PR fixes:
Fixes None
Release Notes: No