Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

URLRewrite filter on empty match prefix #5254

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

sadovnikov
Copy link
Contributor

@sadovnikov sadovnikov commented Feb 11, 2025

What type of PR is this?

Adding a test to demonstrate a bug with the URLRewrite filter.
Not to be merged until #5256 is resolved.

Which issue(s) this PR fixes:

Instead of "/prefix-match/doc", the resulting request will be "/prefix-matchdoc"

Found in end-to-end test logs

not ready yet: expected path to be /prefix-match/doc, got /prefix-matchdoc (after 1.513µs)

Release Notes: No

@sadovnikov sadovnikov requested a review from a team as a code owner February 11, 2025 12:57
Signed-off-by: Viktor Sadovnikov <vsadovnikov@epo.org>
Copy link

codecov bot commented Feb 11, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.88%. Comparing base (c492089) to head (b52de06).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5254      +/-   ##
==========================================
- Coverage   66.94%   66.88%   -0.07%     
==========================================
  Files         210      210              
  Lines       33034    33034              
==========================================
- Hits        22116    22096      -20     
- Misses       9581     9596      +15     
- Partials     1337     1342       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zirain
Copy link
Member

zirain commented Feb 11, 2025

e2e failed as expected, @sadovnikov plan to send a fix?

@sadovnikov
Copy link
Contributor Author

sadovnikov commented Feb 17, 2025

e2e failed as expected, @sadovnikov plan to send a fix?

@zirain, based on the comments in #5256, the fix is not trivial. I hope it will be provided by someone more familiar with the EG code. I'm happy to add more tests but using end-2-end for this seems "too late". Are there unit tests?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants