Bypass overload manager for stats and ready listeners #5321
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rudrakhp
force-pushed
the
bypass_om_stats_ready
branch
from
2debb21 to
d8422af
Compare
|
that was quick 😄 |
rudrakhp
force-pushed
the
bypass_om_stats_ready
branch
from
d8422af to
651b774
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5321 +/- ##
==========================================
+ Coverage 64.92% 64.94% +0.02%
==========================================
Files 213 213
Lines 33454 33455 +1
==========================================
+ Hits 21719 21728 +9
+ Misses 10404 10399 -5
+ Partials 1331 1328 -3 ☔ View full report in Codecov by Sentry. |
|
LGTM, maybe just a release note under "behavior changes". IMHO, this is the correct default behavior, but maybe some folks assume that OM fails checks so that the pods are excluded from the serving set by kube-proxy/externalLB, ... |
|
need changelog |
Signed-off-by: Rudrakh Panigrahi <rudrakh97@gmail.com>
rudrakhp
force-pushed
the
bypass_om_stats_ready
branch
from
651b774 to
8b1fc75
Compare
|
/retest |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Fix: bypass overload manager for stats and ready listeners
What this PR does / why we need it:
Related #5260