fix: panic when getting envoy version #687
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: hexiaodai <jianmin.he@daocloud.io>
arkodg
reviewed
Nov 3, 2022
| @@ -36,7 +36,11 @@ func getVersionsCommand() *cobra.Command { | |||
|
|
|||
| // versions shows the versions of the Envoy Gateway. | |||
| func versions(envOutput bool) error { | |||
| envoyVersion := strings.Split(ir.DefaultProxyImage, ":")[1] | |||
| parts := strings.Split(ir.DefaultProxyImage, ":") | |||
There was a problem hiding this comment.
curious when will we get here ? isn't DefaultProxyImage always a sane constant ?
There was a problem hiding this comment.
I can understand the PR tries to check the slice lower bounds of the default proxy image. But honestly saying, this does not make more sence, because the default image is always naming with a : to sparate the image tag.
If we support custom proxy image, which is not a const but a string parsing from configs, this kind of checks will make more meaningful. But as for the default image, this is no needed for now.
There was a problem hiding this comment.
That's right. I agree with you completely.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: hexiaodai jianmin.he@daocloud.io