Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include Rate-Limit xDS config server related control plane functionality #595

Closed
renuka-fernando opened this issue Oct 3, 2022 · 9 comments · Fixed by #598
Closed

Include Rate-Limit xDS config server related control plane functionality #595

renuka-fernando opened this issue Oct 3, 2022 · 9 comments · Fixed by #598
Assignees

Comments

@renuka-fernando
Copy link
Contributor

renuka-fernando commented Oct 3, 2022

I am working on envoyproxy/ratelimit#201 which is a feature for updating Rate Limit Service configurations dynamically through an xDS server.

As per envoyproxy/ratelimit#201 I thought of adding the server-related implementation within the go-control-plane repository. Then we could re-use most of the readily available functions here. Hence, I created this git issue to discuss how we can achieve this.

Please share your thoughts on this.

RateLimit config proto: envoyproxy/ratelimit#371

@alecholmez
Copy link
Contributor

Hi @renuka-fernando this would be awesome!

I'd actually like to have the rate limit service become a first class citizen of this repo since it's needed for control-plane functionality :)

renuka-fernando added a commit to renuka-fernando/go-control-plane that referenced this issue Oct 13, 2022
envoyproxy#595

Signed-off-by: Renuka Fernando <renukapiyumal@gmail.com>
@renuka-fernando renuka-fernando changed the title Include a sample Rate-Limit config xDS server Include Rate-Limit xDS config server related control plane functionality Oct 18, 2022
@github-actions
Copy link

This issue has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in the next 7 days unless it is tagged "help wanted" or "no stalebot" or other activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale label Nov 17, 2022
@renuka-fernando
Copy link
Contributor Author

hi @alecholmez,

Is it possible to add the "no stalebot" label?

@github-actions github-actions bot removed the stale label Nov 18, 2022
renuka-fernando added a commit to renuka-fernando/go-control-plane that referenced this issue Dec 6, 2022
envoyproxy#595

Signed-off-by: Renuka Fernando <renukapiyumal@gmail.com>
renuka-fernando added a commit to renuka-fernando/go-control-plane that referenced this issue Dec 6, 2022
envoyproxy#595

Signed-off-by: Renuka Fernando <renukapiyumal@gmail.com>
renuka-fernando added a commit to renuka-fernando/go-control-plane that referenced this issue Dec 6, 2022
envoyproxy#595

Signed-off-by: Renuka Fernando <renukapiyumal@gmail.com>
@github-actions
Copy link

This issue has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in the next 7 days unless it is tagged "help wanted" or "no stalebot" or other activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale label Dec 18, 2022
@alecholmez alecholmez self-assigned this Dec 19, 2022
@kkcmadhu
Copy link

hi @renuka-fernando can you kindly add this to java-control-plane too, Please.. It will be super helpful.

@renuka-fernando
Copy link
Contributor Author

hi @renuka-fernando can you kindly add this to java-control-plane too, Please.. It will be super helpful.

sure, I will. Once @alecholmez confirms the changes on go control plane, I will have a look at the java control plane as well.

alecholmez pushed a commit that referenced this issue Jan 27, 2023
…598)

* Add Rate-Limit xDS config server related control plane functionality
#595

Signed-off-by: Renuka Fernando <renukapiyumal@gmail.com>
@kkcmadhu
Copy link

kindly, have this included in java control plane too, i am eagerly awating to try it out.

@renuka-fernando
Copy link
Contributor Author

renuka-fernando commented Jan 31, 2023

Hi @alecholmez,

Missed one more thing, we have to have a way to generate pb files. As we discussed here #598 (comment)

So could you reopen this again to track it? Source proto files: envoyproxy/ratelimit#371

@alecholmez
Copy link
Contributor

@renuka-fernando okay great! Thanks for following up with that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants