-
Notifications
You must be signed in to change notification settings - Fork 521
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Include Rate-Limit xDS config server related control plane functionality #595
Comments
Hi @renuka-fernando this would be awesome! I'd actually like to have the rate limit service become a first class citizen of this repo since it's needed for control-plane functionality :) |
envoyproxy#595 Signed-off-by: Renuka Fernando <renukapiyumal@gmail.com>
This issue has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in the next 7 days unless it is tagged "help wanted" or "no stalebot" or other activity occurs. Thank you for your contributions. |
hi @alecholmez, Is it possible to add the "no stalebot" label? |
envoyproxy#595 Signed-off-by: Renuka Fernando <renukapiyumal@gmail.com>
envoyproxy#595 Signed-off-by: Renuka Fernando <renukapiyumal@gmail.com>
envoyproxy#595 Signed-off-by: Renuka Fernando <renukapiyumal@gmail.com>
This issue has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in the next 7 days unless it is tagged "help wanted" or "no stalebot" or other activity occurs. Thank you for your contributions. |
hi @renuka-fernando can you kindly add this to java-control-plane too, Please.. It will be super helpful. |
sure, I will. Once @alecholmez confirms the changes on go control plane, I will have a look at the java control plane as well. |
kindly, have this included in java control plane too, i am eagerly awating to try it out. |
Hi @alecholmez, Missed one more thing, we have to have a way to generate pb files. As we discussed here #598 (comment) So could you reopen this again to track it? Source proto files: envoyproxy/ratelimit#371 |
@renuka-fernando okay great! Thanks for following up with that. |
I am working on envoyproxy/ratelimit#201 which is a feature for updating Rate Limit Service configurations dynamically through an xDS server.
As per envoyproxy/ratelimit#201 I thought of adding the server-related implementation within the go-control-plane repository. Then we could re-use most of the readily available functions here. Hence, I created this git issue to discuss how we can achieve this.
Please share your thoughts on this.
RateLimit config proto: envoyproxy/ratelimit#371
The text was updated successfully, but these errors were encountered: