[Experiment][Don't review]send alternate rsrc version #290
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jyoti Mahapatra <jmahapatra@lyft.com>
This was referenced Apr 17, 2020
euroelessar
reviewed
Apr 17, 2020
| @@ -161,15 +161,12 @@ func createResponse(resp *cache.Response, typeURL string) (*discovery.DiscoveryR | |||
| Value: resp.MarshaledResources[i], | |||
| } | |||
| } else { | |||
| marshaledResource, err := cache.MarshalResource(resp.Resources[i]) | |||
| marshaledResource, err := cache.MarshalResource(resp.Resources[i], typeURL) | |||
There was a problem hiding this comment.
should discovery.DiscoveryResponse.TypeUrl below be updated as well?
There was a problem hiding this comment.
i see...trying that out.
There was a problem hiding this comment.
There;s still some issue. From envoy logs
[2020-04-17 19:18:00.722][1209][debug][config] [source/common/config/grpc_mux_impl.cc:136] Received gRPC message for type.googleapis.com/envoy.config.cluster.v3.Cluster at version v0
[2020-04-17 19:18:00.722][1209][warning][config] [source/common/config/grpc_mux_impl.cc:139] Ignoring the message for type URL type.googleapis.com/envoy.config.cluster.v3.Cluster as it has no current subscribers.
Signed-off-by: Jyoti Mahapatra <jmahapatra@lyft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Error Message: