Rename ResponseIface to Response #306
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Also return possible error on `GetVersion()` * Update documentation for a few Response functions. * Names the current `Response` struct, containing the raw resources to `RawResponse`. Response was the original name used by cache `CreateWatch()` and `Fetch()` response objects. The current setup alludes to the [implementation Response](https://github.com/envoyproxy/go-control-plane/blob/b12a9ed045da8cd01b3813e0193d1a381ea9e585/pkg/cache/v2/cache.go#L67-L84) being the defacto implementation, which isn't the case anymore with the introduction of a PassthroughResponse struct. Interface is also an implementation detail that should be hidden from the consumer. Signed-off-by: Jess Yuen <jyuen@lyft.com>
jessicayuen
force-pushed
the
rename-ResponseIface
branch
from
6f5fa00 to
e0c8f30
Compare
|
Not sure why CI is failing when I didn't edit any of the v3 files: Script exits cleanly locally. |
|
@jessicayuen , we have to run |
|
Or use |
|
thank you! |
jyotimahapatra
previously approved these changes
Jun 3, 2020
Signed-off-by: Jess Yuen <jyuen@lyft.com>
mattklein123
approved these changes
Jun 8, 2020
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GetVersion()Responsestruct, containing the raw resources toRawResponse.Response was the original name used by cache
CreateWatch()andFetch()response objects.The current setup alludes to the implementation
Response
being the defacto implementation, which isn't the case anymore with the
introduction of a PassthroughResponse struct. Interface is also an
implementation detail that should be hidden from the consumer.
Related: #300
Signed-off-by: Jess Yuen jyuen@lyft.com