Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add nighthawk_adaptive_load_client to our docker image #1088

Closed
oschaaf opened this issue Feb 28, 2024 · 0 comments · Fixed by #1089
Closed

Add nighthawk_adaptive_load_client to our docker image #1088

oschaaf opened this issue Feb 28, 2024 · 0 comments · Fixed by #1089
Labels
enhancement New feature or request

Comments

@oschaaf
Copy link
Member

oschaaf commented Feb 28, 2024

We build a binary [1] for our adaptive load feature, but we do not push it in docker images today.
I think it would be great for accessibility if the binary would be added to the docker image [2] that gets pushed from CI.

[1]

nighthawk/BUILD

Line 16 in 5388e4d

":nighthawk_adaptive_load_client",

[2]

nighthawk/ci/docker/docker_build.sh

Line 15 in 5388e4d

BINARIES=(nighthawk_test_server nighthawk_client nighthawk_service nighthawk_output_transform)

@oschaaf oschaaf added the enhancement New feature or request label Feb 28, 2024
oschaaf pushed a commit that referenced this issue Feb 28, 2024
Add nighthawk_adaptive_load_client to docker_build.sh
eba1b94 
Fixes #1088

Signed-off-by: Otto van der Schaaf <oschaaf@aviatrix.com>
@oschaaf oschaaf mentioned this issue Feb 28, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add nighthawk_adaptive_load_client to docker_build.sh envoyproxy/nighthawk
1 participant
@oschaaf