Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix missing test coverage for --no-duration #370

Closed
oschaaf opened this issue Jun 18, 2020 · 0 comments · Fixed by #384
Closed

Fix missing test coverage for --no-duration #370

oschaaf opened this issue Jun 18, 2020 · 0 comments · Fixed by #384
Assignees
@oschaaf
Labels
tech-debt

Comments

@oschaaf
Copy link
Member

oschaaf commented Jun 18, 2020

In #366 we had to lower the coverage threshold as that PR doesn't come with the means to test the functionality nicely.
This changes with #367. In a follow up we should add an integration test, which should allow restoration of the coverage threshold.
@oschaaf oschaaf changed the title Fix missing test coverage for --no-duration introduced Fix missing test coverage for --no-duration Jun 18, 2020
oschaaf added a commit to oschaaf/nighthawk that referenced this issue Jun 24, 2020
@oschaaf
Cover --no-duration and restore the CI coverage percentage threshold
06634ee 
In envoyproxy#366 we had to lower the coverage threshold as that PR didn't come
with the means to easily cover testing with infinite excecution
durations. Now that we have signal handling in place, we can easily
pull this off.

Fixes envoyproxy#370

Signed-off-by: Otto van der Schaaf <oschaaf@we-amp.com>
@oschaaf oschaaf mentioned this issue Jun 24, 2020
Merged
1 task
@oschaaf oschaaf self-assigned this Jun 24, 2020
mum4k pushed a commit that referenced this issue Jun 25, 2020
@oschaaf
Cover --no-duration and restore the CI coverage percentage threshold (#…
ab496b6 
…384)

In #366 we had to lower the coverage threshold as that PR didn't come
with the means to easily cover testing with infinite excecution
durations. Now that we have signal handling in place, we can easily
pull this off.

Fixes #370

Signed-off-by: Otto van der Schaaf <oschaaf@we-amp.com>
wjuan-AFK pushed a commit to wjuan-AFK/nighthawk that referenced this issue Jul 14, 2020
@oschaaf @wjuan-AFK
Cover --no-duration and restore the CI coverage percentage threshold (e…
b5de7ad 
…nvoyproxy#384)

In envoyproxy#366 we had to lower the coverage threshold as that PR didn't come
with the means to easily cover testing with infinite excecution
durations. Now that we have signal handling in place, we can easily
pull this off.

Fixes envoyproxy#370

Signed-off-by: Otto van der Schaaf <oschaaf@we-amp.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@oschaaf oschaaf

Labels
tech-debt
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Cover --no-duration and restore the CI coverage percentage threshold oschaaf/nighthawk
1 participant
@oschaaf