Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Envoy extension includes aren't available via external/envoy/... #399

Closed
oschaaf opened this issue Jul 9, 2020 · 1 comment
Closed

Envoy extension includes aren't available via external/envoy/... #399

oschaaf opened this issue Jul 9, 2020 · 1 comment
Labels
tech-debt

Comments

@oschaaf
Copy link
Member

oschaaf commented Jul 9, 2020

In the dynamic test server we might use the fault filter as a base class, in which case we need to include
the fault_filter.h. This include isn't available via external/envoy/..., but via extensions/filters/http/fault/fault_filter.h
This can hopefully easily be fixed via a small change in Envoy's build infra, similar to envoyproxy/envoy#8005
oschaaf added a commit to oschaaf/nighthawk that referenced this issue Aug 5, 2020
@oschaaf
Update Envoy to c2b0d37ca5b40b71ce48984f2cf5984297b79a71
7cdda88 
- Updates the extension build config to add ADDITIONAL_VISIBILITY
- Allows fixing of envoyproxy#399: use the right include path for the fault
  filter.

Signed-off-by: Otto van der Schaaf <oschaaf@we-amp.com>
@oschaaf oschaaf mentioned this issue Aug 5, 2020
Merged
@oschaaf
Copy link
Member Author

oschaaf commented Aug 5, 2020

Closing, resolved as of #425

@oschaaf oschaaf closed this as completed Aug 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
tech-debt
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@oschaaf