Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Look into an extension base class for our test server #498

Closed
oschaaf opened this issue Aug 28, 2020 · 0 comments · Fixed by #512
Closed

Look into an extension base class for our test server #498

oschaaf opened this issue Aug 28, 2020 · 0 comments · Fixed by #512
Labels
tech-debt

Comments

@oschaaf
Copy link
Member

oschaaf commented Aug 28, 2020 •
edited
Loading

In #477 we introduce a new extension for tracking (request receipt) timings,
and reflecting those back through response headers. This comes with some code
that handles configuration. This configuration handling is pretty similar across the
extensions, and there are multiple enhancement opportunities there:

  • First it would be nice to factor out a common base for configuration handling
  • Second, once we've done that, we can probably generalize testing of configuration handling,
    creating a TEST_P which verifies all extensions are well behaved there.
@oschaaf oschaaf mentioned this issue Sep 1, 2020
Merged
oschaaf added a commit to oschaaf/nighthawk that referenced this issue Sep 5, 2020
@oschaaf
Server extension: start factoring out common code / functionality.
8204958 
A first step to clean this up. Functional no-op.

Part of envoyproxy#498

Signed-off-by: Otto van der Schaaf <oschaaf@we-amp.com>
@oschaaf oschaaf mentioned this issue Sep 5, 2020
Merged
9 tasks
oschaaf added a commit to oschaaf/nighthawk that referenced this issue Sep 6, 2020
@oschaaf
Server extension: start factoring out common code / functionality.
907587c 
A first step to clean this up. Functional no-op.

Part of envoyproxy#498

Signed-off-by: Otto van der Schaaf <oschaaf@we-amp.com>
oschaaf added a commit to oschaaf/nighthawk that referenced this issue Sep 6, 2020
@oschaaf
Server extension: start factoring out common code / functionality.
7d04ffb 
A first step to clean this up. Functional no-op.

Part of envoyproxy#498

Signed-off-by: Otto van der Schaaf <oschaaf@we-amp.com>
oschaaf added a commit to oschaaf/nighthawk that referenced this issue Sep 6, 2020
@oschaaf
Server extension: start factoring out common code / functionality.
030b56b 
A first step to clean this up. Functional no-op.

Part of envoyproxy#498

Signed-off-by: Otto van der Schaaf <oschaaf@we-amp.com>
oschaaf added a commit to oschaaf/nighthawk that referenced this issue Sep 6, 2020
@oschaaf
Server extension: start factoring out common code / functionality.
1693789 
A first step to clean this up. Functional no-op.

Part of envoyproxy#498

Signed-off-by: Otto van der Schaaf <oschaaf@we-amp.com>
oschaaf added a commit to oschaaf/nighthawk that referenced this issue Sep 7, 2020
@oschaaf
Server extension: start factoring out common code / functionality.
556e836 
A first step to clean this up. Functional no-op.

Part of envoyproxy#498

Signed-off-by: Otto van der Schaaf <oschaaf@we-amp.com>
oschaaf added a commit to oschaaf/nighthawk that referenced this issue Sep 7, 2020
@oschaaf
Server extension: start factoring out common code / functionality.
fe1cfbe 
A first step to clean this up. Functional no-op.

Part of envoyproxy#498

Signed-off-by: Otto van der Schaaf <oschaaf@we-amp.com>
oschaaf added a commit to oschaaf/nighthawk that referenced this issue Sep 8, 2020
@oschaaf
Server extension: start factoring out common code / functionality.
7cf2edd 
A first step to clean this up. Functional no-op.

Part of envoyproxy#498

Signed-off-by: Otto van der Schaaf <oschaaf@we-amp.com>
@oschaaf oschaaf mentioned this issue Sep 24, 2020
Open
@mum4k mum4k closed this as completed in #512 Oct 6, 2020
mum4k pushed a commit that referenced this issue Oct 6, 2020
@oschaaf
Test-server extension: use shared configuration base and test facilit…
9d77161 
…ies (#512)

- Make the test server use the shared configuration handling code.
- Convert its tests to use the new facilities that are shared accross extensions.

Last in a series of PRs to fix #498

This is on par with what we did for the dynamic delay and timing extensions,
but this extension was slightly more complex to begin with, so saving the
best for last ;-)

Signed-off-by: Otto van der Schaaf <oschaaf@we-amp.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
tech-debt
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Test-server extension: use shared configuration base and test facilities oschaaf/nighthawk
1 participant
@oschaaf