Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable IPv6 tests in CI #578

Open
mum4k opened this issue Dec 1, 2020 · 0 comments
Open

Enable IPv6 tests in CI #578

mum4k opened this issue Dec 1, 2020 · 0 comments
Assignees
@mum4k

Comments

@mum4k
Copy link
Collaborator

mum4k commented Dec 1, 2020

Currently we only execute tests using the v4only mode:

nighthawk/ci/do_ci.sh

Line 182 in 4d831ff

export BAZEL_EXTRA_TEST_OPTIONS="--test_env=ENVOY_IP_TEST_VERSIONS=v4only ${BAZEL_EXTRA_TEST_OPTIONS}"

This can cause our IPv6 based integration tests to go stale. We should investigate what is required to enable IPv6 on Circle CI and start running with ENVOY_IP_TEST_VERSIONS=all.

Looks like Circle CI does support IPv6 for local traffic:

https://circleci.com/docs/2.0/faq/#can-i-use-ipv6-in-my-tests
@mum4k mum4k self-assigned this Dec 1, 2020
@mum4k mum4k mentioned this issue Dec 1, 2020
Merged
mum4k added a commit that referenced this issue Dec 2, 2020
@mum4k
Fix integration tests when running with IPv6. (#579)
f5f88e3 
We don't run integration tests in IPv6 mode on CI (See #578). As a result some of the test expectations became invalid.

Also:
- Pytest now displays more logging on test failures including the stderr and stdout of the started nighthawk test server.
- fixing the default IPv6 address, as per `man 3 inet_pton`, the address `::/0` isn't valid, while `::` is.

Signed-off-by: Jakub Sobon <mumak@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mum4k mum4k

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mum4k