Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix_format script always silently passes without formatting anything #913

Closed
dubious90 opened this issue Sep 21, 2022 · 0 comments · Fixed by #916
Closed

fix_format script always silently passes without formatting anything #913

dubious90 opened this issue Sep 21, 2022 · 0 comments · Fixed by #916
Assignees
@dubious90
Labels
bug Something isn't working

Comments

@dubious90
Copy link
Contributor

Description:
See title.

Reproduction steps:
Create an obvious formatting error.
Then run:
ci/do_ci.sh fix_format
Code will pass, despite your new format error
@dubious90 dubious90 added the bug Something isn't working label Sep 21, 2022
@dubious90 dubious90 self-assigned this Sep 21, 2022
@dubious90 dubious90 mentioned this issue Sep 21, 2022
Merged
dubious90 pushed a commit that referenced this issue Sep 23, 2022
Make the fix_format and check_format scripts work on Nighthawk code (#…
73a7bf6 
…916)

Fixes #913

Direct changes:
- Modified config.yaml to not exclude the current directory, which was excluding all of NH
- Overrode some settings in config.yaml to move past some code changes
    - Filed #914 and #915 to address these overrides in the future
- Moved include_dir_order from check_format.sh over to the config.yaml where it now needs to live.

Also ran the format script to fix all current code formatting errors.

Signed-off-by: Nathan Perry <nbperry@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dubious90 dubious90

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Make the fix_format and check_format scripts work on Nighthawk code dubious90/nighthawk
1 participant
@dubious90